Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove use of setup.py #3625

Merged
merged 3 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ jobs:
- name: Install build tools
run: |
python -m pip install --upgrade pip
python -m pip install --upgrade setuptools setuptools_scm wheel
python -m pip install --upgrade build setuptools setuptools_scm wheel

- name: Build packages
run: python setup.py sdist bdist_wheel
run: python -m build

- name: Save built packages as artifact
uses: actions/upload-artifact@v4
Expand Down
4 changes: 2 additions & 2 deletions docs/devel/infrastructureguide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,10 @@ To build and upload manually (if for some reason it is necessary):
2. (optional) Perform a ``git clean -f -x -d`` from the root of the repository. This will
**delete** everything not tracked by git, but will also ensure clean source distribution.
``MANIFEST.in`` is set to include/exclude mostly correctly, but could miss some things.
3. Run ``python setup.py sdist bdist_wheel`` (this requires that ``wheel`` is installed).
3. Run ``python -m build`` (this requires that ``build`` is installed).
4. Upload using ``twine``: ``twine upload dist/*``, assuming the ``dist/`` directory contains
only files for this release. This upload process will include any changes to the ``README``
as well as any updated flags from ``setup.py``.
as well as any updated flags from ``pyproject.toml``.

~~~~~
Conda
Expand Down
22 changes: 0 additions & 22 deletions setup.py

This file was deleted.