New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor after changes in zinolib #24

Closed

2 tasks

podliashanyk opened this issue Oct 17, 2023 · 1 comment · Fixed by #25

Closed

2 tasks

Refactor after changes in zinolib #24

podliashanyk opened this issue Oct 17, 2023 · 1 comment · Fixed by #25

Assignees

Labels

zinolib

Contributor

podliashanyk commented Oct 17, 2023 •

edited

Loading

remove direct usage of Adapters (fixed in Reanalyze events, history, log and decouple from implementation zinolib#18)
fix zino session handling as mentioned by @hmpf in Merge zino and login sessions #18 (after Refactor zinolib config parsing zinolib#22 and Handle sessions, updates and config better zinolib#25 are merged)

podliashanyk added zinolib blocked labels

podliashanyk mentioned this issue

Merge zino and login sessions #18

Merged

Contributor

hmpf commented Oct 17, 2023

HistoryAdapter.add can be replaced with manager.add_history_entry_for_id.

EventAdapter.set_admin_state can be replaced with manager.change_admin_state_for_id.

podliashanyk removed the blocked label

podliashanyk self-assigned this

podliashanyk mentioned this issue

Refactor after changes in zinolib adapters #25

Merged

hmpf closed this as completed in #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment