Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align inputs in forms using CSS instead of <label>&nbsp;</label> #3144

Open
2 tasks
podliashanyk opened this issue Oct 15, 2024 · 0 comments
Open
2 tasks

Align inputs in forms using CSS instead of <label>&nbsp;</label> #3144

podliashanyk opened this issue Oct 15, 2024 · 0 comments
Labels

Comments

@podliashanyk
Copy link
Contributor

podliashanyk commented Oct 15, 2024

Label tags like this <label>&nbsp;</label> are used solely for styling in NAV (which is both semantically ill-suited and a bad practice when it comes to accessibility).
...
So the SonarCloud complaint is technically correct, but factually <label>&nbsp;</label> is not used in form control.

Originally posted by @podliashanyk in #3139 (comment)

Occurrences:

  • python/nav/web/templates/alertprofiles/filter_form.html - alertprofiles/filters/new, alertprofiles/filters/edit/<filter_id>
  • python/nav/web/templates/custom_crispy_templates/submit_field.html - anything calling SubmitField with has_empty_label=True
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant