Implement a link state monitor task #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunkwill42
force-pushed
the
feature/linkstatetask
branch
from
c8d6c2f to
df35715
Compare
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 94.06% 94.88% +0.82%
==========================================
Files 22 24 +2
Lines 1144 1250 +106
==========================================
+ Hits 1076 1186 +110
+ Misses 68 64 -4
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lunkwill42
force-pushed
the
feature/linkstatetask
branch
2 times, most recently
from
c1f58ee to
9f5c354
Compare
lunkwill42
force-pushed
the
feature/linkstatetask
branch
from
3934a0c to
d4c81c8
Compare
We shouldn't need to create the dictionary elsewhere, so its best to default to starting with an empty dict that we can start using immediately.
lunkwill42
force-pushed
the
feature/linkstatetask
branch
from
d4c81c8 to
153afdc
Compare
We do not actually ever need the numerical values from the MIB in our state handling code, as the values are translated to strings for us by the MIB layer. It is therefore better to use a StrEnum, which makes translation from MIB string values easier, and makes the saved state even more human-readable. Also, at least one of the states that Zino 1 operates with, "adminDown" isn't actually a state value from the MIB. It is used to flag the case where an interface operational state is down not because of an error or missing link, but because the administrator has disabled the port on purpose. Because of this, the InterfaceOperState enum was also renamed to InterfaceState (since it doesn't necessarily represent just operstate values).
This makes it easier to annotate other methods that will return or use a data structure that came from the sparsewalk method.
This is an initial re-implementation of the link state monitor parts of Zino 1. Some bits and pieces are still missing, and some TODO points a strewn throughout.
According to Håvard Eidnes, we may need to keep the alias value for non-watched interfaces, especially for PM functionality that comes later. That an interface is not watched only means we shouldn't generate events for it.
These are used by the original Zino for this type of event.
This also factors out state updating and event generation to separate methods.
lunkwill42
force-pushed
the
feature/linkstatetask
branch
from
153afdc to
3341f0d
Compare
stveit
reviewed
Oct 5, 2023
As noted in code review, it's a good idea to log some details whenever we skip updating an interface due to receiving faulty or incomplete SNMP data.
This changes the code flow based on comments from @stveit: Processing a single interface where the collected data is incomplete will raise an exception, while when processing multiple interfaces, single interfaces with issues are just logged and otherwise ignored to not interrupt the flow.
|
Kudos, SonarCloud Quality Gate passed!
|
stveit
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the basics of a link state monitor task, along with some of the necessary changes to the surrounding codebase.
As a side-effect, this also introduces basic test coverage for the zino.tasks module, which had none.
Closes #75