Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Remove PrimaryButton.tsx and SecondaryButton.tsx and DangerButton.tsx & update places they are used #539

Open
jtucholski opened this issue Nov 27, 2024 · 2 comments

Comments

@jtucholski
Copy link
Contributor

jtucholski commented Nov 27, 2024

This issue was refactored out of a previous issue to look at the usage of PrimaryButton, SecondaryButton, and DangerButton and refactor them accordingly.

  • PrimaryButton.tsx and SecondaryButton.tsx are really old components and should no longer be used. In many places now, specifically for forms, we use SubmitButton.tsx, but a new component should be created for more general cases.
  • Clarification needed before turning into ticket
    • Decide on a look for buttons that are not submit. Ideally these would look slightly different as they have different functionalities, but some more research might be helpful on best UI practices.
@jtucholski
Copy link
Contributor Author

@calisio I think that this is something you brought up in a different ticket when we discussed some refactoring. Without digging too deep, do you know of any more context that we should add to this issue right now?

@calisio
Copy link
Contributor

calisio commented Nov 27, 2024

The places that these buttons are used should instead use the class button and it should apply the necessary styling. There are several examples (such as the Add Provider button on provider platforms) that it should look like. Please do not use btn btn- classes, these are daisy ui styling we want to move away from!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants