Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latitude and Longitude types are inconsistent w/ graphql-codegen #2168

Open
4 tasks
jacob-israel-turner opened this issue Oct 18, 2023 · 0 comments
Open
4 tasks

Comments

@jacob-israel-turner
Copy link

jacob-israel-turner commented Oct 18, 2023

Issue workflow progress

Progress of the issue based on the Contributor Workflow

  • 1. The issue provides a reproduction available on GitHub, Stackblitz or CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.

Please make sure the GraphQL Scalars package version under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug
The Latitude and Longitude codegen types are inconsistent. Latitude is string, Longitude is string | number. This results in inconsistent generated types in clients using graphql-codegen.

To Reproduce
Steps to reproduce the behavior:

Create a GraphQL schema using both latitude and longitude, then generate types using GraphQL Codegen. You will see latitude: string and longitude: string | number are the generated types.

Expected behavior

Latitude and Longitude should both generate the same types - probably string | number.

Environment:

  • OS: N/A
  • GraphQL Scalars Version: 1.22.2
  • NodeJS: v18

Additional context
If I have time, I'll submit a little PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant