Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

feat: add search box to results and source answers views #22

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jorgecoca
Copy link
Member

@jorgecoca jorgecoca commented Nov 28, 2023

Description

This PR adds the search box to all the views where it is supposed to show up. The next step is to distinguish between the Ask mode and the clear text mode, which I can address in a separate PR.

Screen.Recording.2023-11-27.at.7.48.22.PM.mov

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@jorgecoca jorgecoca self-assigned this Nov 28, 2023
Copy link
Contributor

@RuiMiguel RuiMiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@omartinma omartinma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgecoca LGTM. Not related to the component but we might need to update the answer box to avoid the scrollable view in "normal" screen size

@omartinma omartinma merged commit 3e96e3a into main Nov 28, 2023
4 checks passed
@omartinma omartinma deleted the feat/search-text-fields branch November 28, 2023 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants