Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directmlでGPUが使えなかったことに対する対処 #236

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

qwerty2501
Copy link
Contributor

@qwerty2501 qwerty2501 commented Aug 13, 2022

内容

with_append_execution_provider_directml の呼び出しが行われていなかったのが原因であると思われるため、呼び出しを行うようにした

関連 Issue

VOICEVOX/onnxruntime-rs#6 がmergeされないとreviewできない
できるようになった!
#213

その他

@@ -7,7 +7,7 @@ on:
- published
jobs:
rust-lint:
runs-on: ubuntu-latest
runs-on: windows-latest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with_append_execution_provider_directml はwindows向けであるため、現状すべてのfeatureに対してbuildが通るのはwindows環境となるためlintではwindowsで行うようにした

@qwerty2501 qwerty2501 force-pushed the fix/directml-cant-use-gpu branch from 67b5a8e to 4805588 Compare August 16, 2022 14:45
@qwerty2501 qwerty2501 marked this pull request as ready for review August 16, 2022 14:45
@qwerty2501
Copy link
Contributor Author

これもレビューできるようになったと思います

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@qwerty2501 qwerty2501 force-pushed the fix/directml-cant-use-gpu branch from 4805588 to 2492ef1 Compare August 17, 2022 04:18
@Hiroshiba
Copy link
Member

大丈夫だと思うのでマージします!

@Hiroshiba Hiroshiba merged commit 3c08d3d into VOICEVOX:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants