Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ P256 decodePoint #1168

Merged
merged 2 commits into from
Nov 21, 2024
Merged

✨ P256 decodePoint #1168

merged 2 commits into from
Nov 21, 2024
+44 −0

Conversation

Vectorized
Copy link
Owner

Description

85 gas less than abi.decode(encoded, (bytes32, bytes32)).

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

Gas Snapshot Comparison Report

Generated at commit : 7f8647d, Compared to commit : 1dd8967

Contract Name Test Name Main Gas PR Gas Diff
P256Test testP256VerifyNonMalleableRIPPrecompile() 341117 341095 -22
testP256VerifyNonMalleableVerifier() 341095 341162 67
testP256VerifyOutOfBounds() 201377 201399 22
testP256VerifyWycheproof() 3268 3246 -22
test__codesize() 11401 12016 615

@Vectorized Vectorized merged commit 7955751 into main Nov 21, 2024
11 checks passed
@Vectorized Vectorized deleted the p256-qol branch November 27, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vectorized