Unable to use join action due to incorrect IP address being fetched
#69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't been able to use the join action from Home Assistant using the native Linkplay integration. After debugging it, I noticed that it was sending
0.0.0.0as the address for the main device.The reason was that the correct address was being returned by
eth0, witheth2being0.0.0.0. Theforloop was supposed to correct it and set the value of0.0.0.0addresses toNone, but since strings are immutable it wasn't changing the string value referenced byeth2. I've simplified the code to use a sequence ofifstatements until one with a valid address is found.