Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(silentTyping): make button/icon visual look better #3026

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

xNasuni
Copy link

@xNasuni xNasuni commented Nov 20, 2024

before:
image
after:
image

:3

@xNasuni xNasuni changed the title make silentTyping chatbar button look better feat(silentTyping): make button/icon visual look better Nov 20, 2024
@Vendicated
Copy link
Owner

this looks very out of place because it is wider than the other icons. that's why the old icon was smaller

optimally we'd just use a different proper square icon

image

@xNasuni
Copy link
Author

xNasuni commented Nov 21, 2024

the reason I had used a bigger size (36 x 28) was because I thought it looked more odd if it WASN'T scaled up to fit the height of other buttons, it also made it bigger in width, which looking back wasn't really the best move

I sized it back down to 24x24 like all the other chatbar buttons and I think now it does look better.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants