Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDNs are not handled correctly #56

Open
mgrzeca opened this issue Apr 19, 2024 · 1 comment
Open

IDNs are not handled correctly #56

mgrzeca opened this issue Apr 19, 2024 · 1 comment

Comments

@mgrzeca
Copy link

mgrzeca commented Apr 19, 2024

It's impossible to find a user whose user handle has an IDN as the domain part. Below is an example and a log excerpt:

Zrzut ekranu 2024-04-19 o 13 02 14
vernissage-api  | [ INFO ] GET /api/v1/search [request-id: B056B3FE-F30C-4817-83FF-223CC9EDA788]
vernissage-api  | [ NOTICE ] Base url cannot be parsed from user query: 'north@ꩰ.com'. [request-id: B056B3FE-F30C-4817-83FF-223CC9EDA788]

You can find such a user by manually converting the user handle to Punycode. However, in this case, the displayed name is incorrect (Punycode instead of IDN):

Zrzut ekranu 2024-04-19 o 13 02 38
@mgrzeca
Copy link
Author

mgrzeca commented Apr 19, 2024

Yeah, I know IDNs are cancer and a potential security threat due to homograph attacks, but they've been around for a while and they're here to stay, so they should be handled properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant