New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add / improve test messages #1

Open

raingerber opened this issue Apr 4, 2018 · 0 comments

Contributor

raingerber commented Apr 4, 2018

Problem description:

Many of the tests do not have names, or the name is not descriptive enough:

// missing
it('', () => {
  expect(evaluate('')).toBe(undefined)
})

// room for improvement
it('invalid', () => {
  expect(() => throwForInvalidSequence('+', '+')).toThrow()
})

Suggested solution:

Add names to all the tests, and review / rephrase existing names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment