Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build scalafmt native images for macOS ARM too #3236

Open
alexarchambault opened this issue Oct 21, 2024 · 3 comments
Open

Build scalafmt native images for macOS ARM too #3236

alexarchambault opened this issue Oct 21, 2024 · 3 comments
Labels
blocked upstream Issues and changes blocked by something in an external project. enhancement New feature or request fmt Issues tied to the fmt sub-command

Comments

@alexarchambault
Copy link
Contributor

Is your feature request related to a problem? Please describe.
VirtusLab/scalafmt-native-image only builds macOS native images of scalafmt for x86-64, not for aarch64.

Describe the solution you'd like
Like VirtusLab/coursier-m1, it should have access to an M1 worker, so it should be able to build images for macOS ARM.

@alexarchambault alexarchambault added the enhancement New feature or request label Oct 21, 2024
@Gedochao Gedochao added the fmt Issues tied to the fmt sub-command label Oct 21, 2024
@Gedochao
Copy link
Contributor

Since scalameta/scalafmt#4325 recently got merged, VirtusLab/scalafmt-native-image should no longer be necessary and the native images should be built with Scala Native in the scalameta repo instead.
This applies to the MacOS arm native images as well, since we can now use the official GitHub runners for this.

Either way, I'm thinking this should be raised upstream rather than here.

@Gedochao Gedochao added the blocked upstream Issues and changes blocked by something in an external project. label Oct 21, 2024
@alexarchambault
Copy link
Contributor Author

@Gedochao Did Scala CLI switch to launchers generated from scalameta/scalafmt already?

@Gedochao
Copy link
Contributor

Not yet. We should, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked upstream Issues and changes blocked by something in an external project. enhancement New feature or request fmt Issues tied to the fmt sub-command
Projects
None yet
Development

No branches or pull requests

2 participants