-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VERPAT output structure violates VisionEval architecture #142
Comments
Looking forward to seeing this issue resolved, as I'm planning to use VERPAT soon. Just did a run-through with the default data and encountered this error. What is a work around for the time being? Thanks! |
There are some workarounds. First of all, you can use the Let's run the default VERPAT model:
To get the Vehicles outputs, you can take advantage of First, you can query the entire datastore to find out all available variables for outputting. Assuming you have just run the demo VERPAT model, do the following (thanks to @gregorbj for building this functionality and sharing example code!):
Then, make an inventory of the datastore This creates a zip archive which documents all the datasets in the datastore.
Now look at the outputs in the documentation: The Vehicle.csv file will tell you what variables are available. We can choose variables from this to extract. First, write a list named The named components are tables; each component is a named vector where the names are the names of datasets and the values are the units that the data is to be retrieved in "" means retrieve the data in the units used in the datastore.
Then call the
The readDatastoreTables function returns a list having two named components: "Data" and "Missing"
The first six out of 599,198 rows: |
Note that the VE 3.0 version of extract for model results will successfully create two Vehicle tables for VERPAT (based on the different number of rows in the alternate futures). So currently, everything "works" for extraction. I expect the integrated query system will fail for anything that might get pulled out of both "halves" of the vehicle table. The deeper fix of restructuring VERPAT's vehicle outputs is very much still on the table. |
The data-handling functions in VisionEval used for query and extraction expect the Datastore Group/Table/Name structure to have all the "Name" vectors (Datasets) the same length (corresponding to the Table's key field, such as HhId or VehId).
The VERPAT model, however, does not respect that requirement and puts a number of differently-sized vectors into the same tables. That leads to two failures when we try to read through the model results in "tabular" or "data.frame" structure.
The correct solution is to ensure that within VERPAT and its model-specific modules, each Dataset is written into a Table with a unique number of rows corresponding to the Table's key field(s).
Two fixes are required in the module code:
The text was updated successfully, but these errors were encountered: