Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form callbacks #144

Open
eric-burel opened this issue Oct 3, 2022 · 0 comments
Open

Form callbacks #144

eric-burel opened this issue Oct 3, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@eric-burel
Copy link
Collaborator

Describe the bug

  • addSuccessCallback/addFailureCallback, that can be called from a child component to enhance the context, leads to infinite loop. Those functions modify the state, so maybe there is another loop that runs on callbacks, modifying it as well?
  • those callbacks are not used anyway...
  • callbacks should be passed to the form via top-level props and then spread into the context. We can probably initialize the context accordingly.

Expected behavior
User can set callbacks from form, and can safely call the "addCallback" methods from within another component (or we deprecate this altogether)

@eric-burel eric-burel added the bug Something isn't working label Oct 3, 2022
@eric-burel eric-burel self-assigned this Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant