Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic scaling of quiverdata #52

Open
dilaraabdel opened this issue Nov 26, 2024 · 3 comments
Open

Automatic scaling of quiverdata #52

dilaraabdel opened this issue Nov 26, 2024 · 3 comments
Labels
bug Something isn't working question Further information is requested urgent Working on this has a high priority

Comments

@dilaraabdel
Copy link

Is there a reasoning behind automatic scaling of quiverdata via setting vnormalize = true by default here?
For me, it would make sense to have the normalization false by default, but maybe I am missing something.

Background: Currently, I am using the quiverdata method for visualizing current densities for different set-ups. As I want to compare these vectorfields, it is important that I do not have any automatic scaling.
My results seemed to be a bit strange, I thought, because of some scaling from PyPlot, as I realized now there is some scaling happening through GridVisualize ...

@jpthiele jpthiele added bug Something isn't working question Further information is requested urgent Working on this has a high priority labels Nov 26, 2024
@j-fu
Copy link
Member

j-fu commented Nov 27, 2024

I recall that I wanted to have a default which works reasonably well out-of-the box. Automatic scaling should prevent arrows which are too long or too short compared to the size of the domain.

May be it is not good enough though. If you have an example I could look into this.

@jpthiele
Copy link
Contributor

If I understood this correctly, the problem is not that the scaling is bad per se,
but that it makes comparing two fields with different maxima and minima very difficult.
Maybe we could add the option to supply a maximum and minimum for scaling?

@j-fu
Copy link
Member

j-fu commented Nov 27, 2024

Setting vnormalize to false and vscale to some common reasonable value should make this possible. If this doesn't work I would consider this a bug. Not sure how a better API could look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested urgent Working on this has a high priority
Projects
None yet
Development

No branches or pull requests

3 participants