Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify test_doper - softmax add up to 1 #197

Merged
merged 4 commits into from
Apr 2, 2024
Merged

modify test_doper - softmax add up to 1 #197

merged 4 commits into from
Apr 2, 2024

Conversation

JiwooChloeLee
Copy link
Contributor

@JiwooChloeLee JiwooChloeLee commented Jan 1, 2024

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Modified test_doper.py file as doper.py file supports softmax function. The new feature in test file checks whether the sum of softmax number adds up to 1 or not.

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Python version:
  • Operating System:

Reviewers

@mention individuals who you specifically want to involve in the discussion for this pull request and mention why they are needed in the discussion/why they are needed to review the pull request.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@AntObi
Copy link
Collaborator

AntObi commented Jan 1, 2024

@JiwooChloeLee The CI is currently failing at the qa stage. On your fork, you'll need to run pre-commit to get the SMACT CI to pass.

Steps:

  1. From the SMACT directory, run pip install -r requirements-dev.txt
  2. Run pre-commit run --all-files
  3. Push the modified files to this branch

@JiwooChloeLee JiwooChloeLee merged commit 3a2b9f3 into WMD-group:master Apr 2, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants