Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into develop branch #335

Merged
merged 31 commits into from
Nov 28, 2024
Merged

Merge master into develop branch #335

merged 31 commits into from
Nov 28, 2024

Conversation

AntObi
Copy link
Collaborator

@AntObi AntObi commented Nov 28, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Introduced sorting option for species occurrences in the oxidation states filter.
    • Added a new tutorial on filtering ICSD oxidation states.
  • Bug Fixes

    • Enhanced error handling in various functions to accommodate input lists of differing lengths.
  • Documentation

    • Updated versioning in documentation files to reflect the latest release.
    • Improved clarity in tutorial content and examples.
  • Tests

    • Adjusted tests to accommodate new parameters and improve robustness against varying input sizes.

AntObi and others added 30 commits November 21, 2024 13:58
Merge the develop branch into the master branch
Download crystal space optional dependencies in ci
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Try MP_API_KEY in Github Actions
Fix documentation and tutorial notebooks ahead of new release
Copy link
Contributor

coderabbitai bot commented Nov 28, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request encompass updates to the CI workflow, documentation, Jupyter notebooks, and various Python files. Key modifications include enhancements to dependency management in the CI configuration, version updates in documentation files, and improvements to several Jupyter notebooks for clarity and functionality. Additionally, updates to Python files involve changes to method signatures, the introduction of new parameters, and adjustments to error handling, particularly in relation to the handling of zipped sequences and the parsing of species data.

Changes

File Path Change Summary
.github/workflows/ci.yml Updated dependency installation command to include optional extras; added MP_API_KEY env variable for tests.
docs/conf.py Version updated from "2.7" to "2.8"; release updated from "2.7.0" to "2.8.0"; branch reference changed to "master".
docs/examples/oxidation_states.ipynb Updated imports, modified output of get_included_species, refined print statements, and changed structure loading method.
docs/requirements.txt Updated tornado package version from 6.4.1 to 6.4.2.
docs/tutorials.rst Reordered tutorial entries and added a new tutorial entry for filtering_icsd_oxidation_states.ipynb.
docs/tutorials/crystal_space.ipynb Enhanced markdown content, updated Colab link, modified package installation command, and changed kernel specification.
docs/tutorials/crystal_space_visualisation.ipynb Updated Colab link, consolidated installation commands, and modified kernel specification.
docs/tutorials/oxidation_states.ipynb Updated hyperlink to point to the master branch; no changes to logic.
docs/tutorials/smact_generation_of_solar_oxides.ipynb Updated Colab link, modified installation command, and changed kernel specification and Python version.
docs/tutorials/smact_validity_of_GNoMe.ipynb Updated Colab link, modified data loading path, and changed kernel specification and Python version.
pyproject.toml Updated project version to 2.8, relaxed pymatgen version constraints, added new optional dependencies, and updated tool configurations.
smact/__init__.py Updated attribute name from oxidation_states_icsd to oxidation_states_icsd16.
smact/builder.py Modified zip function calls in cubic_perovskite and wurtzite functions to include strict=False.
smact/data_loader.py Updated dictionary construction in lookup_element_data to include strict=False in zip.
smact/dopant_prediction/doper.py Added strict=False to zip in _merge_dicts method.
smact/screening.py Updated zip calls in multiple functions to include strict=False; modified oxidation_states_set parameters.
smact/structure_prediction/mutation.py Added Callable to imports and updated alpha parameter in methods for explicit type hinting.
smact/structure_prediction/structure.py Added strict=False to zip calls in parsing methods and refined error handling in from_mp.
smact/structure_prediction/utilities.py Updated parse_spec function with new logic and added _parse_spec_old for fallback parsing.
smact/tests/test_core.py Updated test parameters for test_smact_validity to reflect new oxidation state definitions.
smact/tests/test_doper.py Added strict=False to zip in test_dopant_prediction.
smact/tests/test_structure.py Updated zip calls in tests to include strict=False for flexible iteration.
smact/tests/test_utils.py Adjusted test conditions with pytest for improved error handling and added cleanup steps.
smact/utils/composition.py Added strict=False to zip calls in comp_maker function and updated docstring.
smact/utils/crystal_space/generate_composition_with_smact.py Added strict=False to zip calls in convert_formula and main function.
smact/utils/oxidation.py Updated get_species_occurrences_df method to include sort_by_occurrences parameter.

Possibly related PRs

Suggested labels

dependencies, bug, enhancement, docs, feature

Poem

🐇 In the garden where changes bloom,
New paths are forged, dispelling gloom.
With dependencies spruced and docs refined,
Our code hops forward, well-aligned.
Let tests run free, with errors tamed,
In the world of SMACT, we’re unashamed! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@AntObi AntObi merged commit 4b7c55a into develop Nov 28, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant