Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated QR is not scanned by wallets. Kotlin Modal QR works at the same time #51

Open
Raenar4k opened this issue Feb 7, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@Raenar4k
Copy link

Raenar4k commented Feb 7, 2024

Describe the bug
As title - Kotlin version of Modal works fine, but swift samples QR is not recognized by wallets.
Here are both side by side
image
image

@Raenar4k Raenar4k added the bug Something isn't working label Feb 7, 2024
@llbartekll
Copy link
Collaborator

hey @Raenar4k could you check last version?

@Raenar4k
Copy link
Author

After pulling updates and building - i get this error while running.
So i cannot get to QR part
image

@llbartekll
Copy link
Collaborator

@Raenar4k could you try to upgrade to 1.3.1?

@Raenar4k
Copy link
Author

@llbartekll
Now sample works, yes.
It generates this QR, which is not recognized. Im testing on Metamask, which works for kotlin sample
image

@llbartekll
Copy link
Collaborator

@Raenar4k could you give me steps to reproduce or make a screen recording?
I'm connecting with MetaMask without any issues

@Raenar4k
Copy link
Author

@llbartekll
Sure. Here are 2 emulators side by side - kotlin WC demo and swift WC demo.
Scanned by android device - Pixel 7 pro, by metamask app
https://github.com/WalletConnect/web3modal-swift/assets/13849790/9d0ad9d4-b515-488c-9300-461c71b1f19b

@llbartekll
Copy link
Collaborator

I just tried to reproduce and I experience no issues when scanning qr code with Kotlin wallet.

@Raenar4k
Copy link
Author

Raenar4k commented Mar 20, 2024

with Kotlin wallet.

I also have no issues when scanning QR from Kotlin wallet.
It is Swift version on iOS emulator that is not recognized @llbartekll

@llbartekll
Copy link
Collaborator

It is Swift version on iOS emulator that is not recognized

yes, this is what i mean, swift dapp and any wallet(kotlin and swift) connects. can you try to copy/paste the uri?

@Raenar4k
Copy link
Author

I used 3rd party QR scanner - reading URI and then clicking on it works - Metamask connects and app shows balance, signing message also works.
Trust wallet also connects, but lists all chains for some reason, when i selected only etherium.

There is an issue with image of QR code generated by dapp.
So i've recorded a little test - where i use link from swift dapp and generate QR code with its contents - and it works instantly.

qr_test.mp4

@llbartekll
Copy link
Collaborator

hmm, this is interesting, on ios im able to scan the qr code with any wallet, including MetaMask and all works
Do you experience the issue when you scan the qr code with other wallets? or only metamask?

@Raenar4k
Copy link
Author

Same issue with TrustWallet.
Did not test on others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants