Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issnan function needs work. #8

Open
WarrenWeckesser opened this issue Jun 30, 2024 · 0 comments
Open

issnan function needs work. #8

WarrenWeckesser opened this issue Jun 30, 2024 · 0 comments

Comments

@WarrenWeckesser
Copy link
Owner

From https://en.cppreference.com/w/cpp/types/numeric_limits/signaling_NaN,

In IEEE 754, the most common binary representation of floating-point numbers, any value with all bits of the exponent set and at least one bit of the fraction set represents a NaN. It is implementation-defined which values of the fraction represent quiet or signaling NaNs, and whether the sign bit is meaningful.

So the bit-twiddling done in https://github.com/WarrenWeckesser/ufunclab/blob/main/src/issnan/issnan_ufunc.c.src is not gauranteed to work.

When the code is updated, it should make use of the appropriate features of the standard library and any relevant macros provided by the compiler:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant