Popup Templates Support #64
Conversation
|
Please test 👀 |
There was a problem hiding this comment.
In it's current form this ejs template implementation is much much slower than master. I tested all of the templates with simple changes and they worked but filters like spawnpoints, submission cells, and s2 cells ended up taking the browser much longer to render when on this PR.
Additionally it locks the UI while it's attempting to render so it looks like it simply crashed. Waiting long enough does have the rendering complete.
Third point using /templates is not git friendly. I recommend putting the default templates some where inside of /src then have /templates/foobar.example.ejs files. Modify gitignore with
/templates/*
!/templates/*.example.ejs
When changes happen git won't prompt admin's to stash, commit, etc with local changes.
versx
force-pushed
the
popup-templates
branch
from
daac169 to
fe1480d
Compare
|
Should probably look at #200 while you're at it. |
Should be fixed now, last thing is the raid popups still shift to the left. Normal gym icons are fine though. |
There was a problem hiding this comment.
Still finishing up some work before more testing but some initial feedback:
-
Scan Area is a bit sluggish, manageable, but maybe not necessary unless someone more creative than I can envision how these can be further customized?
-
Pokemon also seem a bit sluggish, I don't remember them being this slow when I tested this previously.
-
Pokemon image is stretched (Desktop, chrome)
-
Quests & Invasions seem fine
-
Pokemon in the raid popup also stretched, I think maybe we revert the recent commits? I'm not that worried about the ultra ball catch rate being on a separate line.
-
Nests are also sluggish, I'm guessing this is related to the polygon drawing, similar to scan areas.
-
Weather is sluggish
-
I would suggest having a templates.example directory then have people copy the folder and rename to templates, instead of having to copy and rename each template file.
🤔 Seems fine to me? |
|
@versx Use an icon pack that is not square. |
Shuffle Pogo Home |
|
God damn it I bet it works fine on Koffing too. |
|
spot what is wrong with this pic |
I know the type icons are shifted to the left |
|
|
|
|
|
Ok that's more obvious! 😂 |
|
Fix it or we are not merging your patch into our map. |
What if I can't? Will you help with your map? 😂 |
|
As a matter of fact, I will probably just delete your entire PR. If map admin wants to change a template, they can just edit js code. |
|
Introduces the functionality to customize your own marker popup contents for the following:
Spawnpoints(removed for performance issues)S2 Scan Cells(removed for performance issues)S2 Submission Cells(removed for performance issues)TODO: