-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing incidents with display_type=9 on map #1007
Comments
This seems like an issue for Golbat. |
Seems to be an edge case, as golbat cleans incidents when expired every few minutes/hours? |
Now as I followed your discussion on the server I know what you mean:
@kamieniarz can you pls post db row? Imo thr GMO contains the expiry date, without lookup |
There is expiration date without lookup and it's been like that proly since forever Here's pokestop table
And incident table
It's not an edge case. Simply new showcase without lookup |
That's why I added second comment ;) |
Does this accurately returns the incidents in question? SELECT * FROM golbat.incident WHERE pokestop_id IN (SELECT id FROM golbat.pokestop WHERE showcase_expiry < unix_timestamp()); The sub query, the one selecting the IDs with stops that have expired showcases returns 46 on its own from my very large pokestop table. The entire query doesn't return anything though... |
...to add some data, I got 233 results w above sub query, and 14 results in full query. |
@Fabio1988 I was on mobile ;) Edited message |
@TurtIeSocks 331 results that expire in 18 min |
Can you describe what filters are on (or off) to replicate this behavior? As well as what you see exactly (screenshots please) and what you would expect to see? |
Please try |
Too late. I'll have to wait for another event cause showcases are gone in 1min. And it's not an edge case unless you lookup every single showcase - then it simply won't be a case. Imagine you lookup all showcases possible, in whole country. And on next event you don't do that but instead you scan whole country with fort mode only. You won't see any showcase on map |
Then go test in nyc with scannext and be nice ;) |
I wonder if Golbat should also update showcase_expiry column of pokestop to the value from gmo incident... Imo this column should only be in incident table :/ |
@Fabio1988 I can't just go to nyc. I'd have to mess around in db to recreate |
Already scanned nyc? Then Santa monica pier :) |
I think you don't understand the issue... To scan nyc and expect to recreate the issue there I'd have to have in db showcases from nyc that already expired. I don't have such cause I never scanned nyc. All I can do is modify my db to recreate or wait for another showcase event. I prefer the latter |
So with a fresh gmo scan this doesn't happen and RM showing the showcase? Even with no showcase details |
Issue won't occur if you have no data in showcase related fields in pokestop table. So yeah, if you use only GMO scan without showcase lookup and never did showcase lookup in that specific area - issue won't happen. But as said earlier, if you scan whole city/country/whatever using showcase lookup, event ends and on next showcase event you use GMO scan only - you won't see any showcase on map. |
I checked out branch |
@TurtIeSocks I can also confirm that |
I've also noticed an interesting state, when showcase wasn't fully scanned. It was displayed with correct end date, but challenge type and mond from ranging were taken from previous showcase that ended 😬 But I guess this specific state is nothing rm could handle. Anyway main issue still occurs unless it was meant to be fixed in latest commits - I haven't tried these yet |
Haven't touched this issue because I still can't replicate. Someone who's experiencing it will need to be the one to address it. |
It's easy to replicate. Scan area with mons and on new showcase event scan same area with fort mode only |
There's a case when showcases with no details are not displayed on map. So basically pokestop has in db display_type=9, expiration is in future but map displays nothing on that pokestop proly cause it holds expired showcase (showcase_expiry) from the past. In fact there should be a logic that displays incident instead of showcase when incident.expiration>pokestop.showcase_expiry and incident.display_type=9
The text was updated successfully, but these errors were encountered: