[Feature Request]: Exclude rocket grunt toggle & exclude rocket leader toggle #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TurtIeSocks
requested changes
Jun 19, 2024
|
I tested the code when it was on the main branch with success. It would be amazing to have an equivalent of the Quest Conditions advanced filter, although I understand if it would be out of scope. |
|
Ready for review now! |
TurtIeSocks
requested changes
Jun 21, 2024
|
Updated the branch back to |
TurtIeSocks
approved these changes
Jun 22, 2024
|
🎉 This PR is included in version 1.33.0-develop.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 toggles to further filter Rocket Pokemon:
Exclude Rocket Leaders&Exclude Rocket Grunts.It should be noted that I've only tested this with a limited data setup (actually just 2 pokestops, one with character ID 16, and one with character ID 41), so it could use a test with a larger set of data. I don't have a scanner set up so I'm unable to do this