Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding the glow of an external element is not working #4624

Closed
2 tasks done
nookthanx opened this issue Sep 30, 2023 · 1 comment
Closed
2 tasks done

Hiding the glow of an external element is not working #4624

nookthanx opened this issue Sep 30, 2023 · 1 comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@nookthanx
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

let's say I am making a proc glow condition for an external element (action button) to be shown at 3 seconds left on the buff and no matter what condition I will make to hide it (e.g. leaving combat or buff expiration) the button remain glowing forever. It's hidden only on /reload or when you press it again so the buff is activated

WeakAuras Version

5.7.1

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

EU

Tested with only WeakAuras

  • Yes

Lua Error

No response

Reproduction Steps

  1. Create a trigger for any buff which is activated by pressing an ability (in my case it's id268877)
  2. Create 1st condition for it to trigger a glow of an external element (action button) when 3 seconds remains of the buff
  3. Create 2nd condition to hide this glow on action button at no buff available or at >3 seconds of the buff

Last Good Version

No response

Screenshots

image

Export String

!WA:2!1vv3UTrru4AzqGmsqRlevIIqHaejQGiiTnPcPwjVj20wCIdR32uOPYE2DhV7qwpZYmZ6ehrPPUuAl)1Ibj(5om3YfOiqCFEcMAvXdqUGhG8eWzM1UPTQjxKDoN58735BootP8nZ7N3)wVwpIhJwLLW9WJDa(6vA0qGL)gVD6HmBHOEHm(smcv6oxXfDkA33JXI8zRrRUgjgxF7HIf9dWHw6WvVJKtccWCXZpjFWX)LNiWlIAIR3fLWru4Kyu3PN5KNC2z5G3vOrTRBJBHH8CgmksgUJiX1iVeh3GSUD1LkwUCVekrwCDIqk2ZGQjnad2Q2CfQ6uRQtbBNoIyCu0z9f5S0o4ghHAJ52MSMRFtK0lelQgYwRcDBH5tbpjPf2s2ogBRlWP75JDH46ak4NPy5LkD(YDtOd6MCXhczCWjvEbMp(poWUaiH5uu0fGwNWO3y3vX44cqT4jTrsclSRah1WaMQNgsGajHujXH9GwXgha(iEVruJ1heDrERgWzju)BnACEjEDznrica6loy0e)YgLM)1GXHMQMyWblkJI7(GRN4nIFcghp4GTK0e7VtAggwEwfoVtL4dBuIsKmWoI3YeFzOvbqC30arwh7BuET4x)jeFDGRfHdqETR1iIX4HBBm4tsessJ2aeWzsO9DaLwlwzXIXV6(fLyo2JOX0SQX4a6OnPFk3CiE0Z4MhlIXpxw4VUdcdvgFWsCYgJ)HjiFaTrJ74eFWhcqNZ4sMmzY(i48hniUP1Cli7Ur4W(gP1yC)L5O4olp4q)hKmdHPY5DkFwOFstZd9gQlCtr7Aovwk(v2VEnvkt847Nbnz(100M67L1QKnWVD8BUFE43gO(eVAYqog47r(ThaEdBY)RFqeBTsC8NMGPETx6PENPM(ePqT(IT1)BEnxvpc6OL09zF3ePKrR0cZHhy90QlJPbYWxAl95HbVRwyUhmy2g2e8(d1eASC4m0ufoHeVvPyHiRXXQEOiCwl9XqJIYe4YdzYMfa)yEOBiMeekVKved53YsaGXi2ntIKKC74fHecye4xt)oCsxbHgeHV)lOUCoxjezQCe1Lh5izU9PRBPTaKYfNhkXApQN1TnY6R7PVn13WECZZwnAOE2Pti(BToYN264BmZSbf6dpDaqUsSg2e52IqthlGuoUEbcODgBHeXL5CBqOeryol4JmN9E844xC4gw97K5jceWd9d7jzETs3ZCKm385MG4hFy1VR(l1FEVnhx9pQTu)9928E3XEn97ZlzJIIdrz3nDQxIdlc1LSB15SlwCrt)o3GSa7YS1KlxytEdsqooHQZdoCRgA3Qk1VHYATbJ1mLM0dm0NyAMZnPnSz1B1sQCz70cXj6ADh86XKuQJdqgTBHIsW5p2eS4jo1P4EHiAaw8XtQU6m9e69D10lHTwcyu2g54zoREVAdKhELc((vOIvwgJwTaqhfRSa2NGwPQ2oXkFarkX0fWS1MIfe0pnA6eqXrUZtqrSGoXCg8av2wDDiJTv3uPZ8f2vZMQzAqt67xYUWcfRwSCX5CQy3BVB7xWm2Sme)JB4JdQxoZBhJOzEwGsAw3WTRLoOT0)oJ6MMxsWC087edQaEUjvFMgYuxr95PWI6Q5NwTPbuuxt1rDD1xOUH6lbJFKYwDl1Tv3rDx13O(w13vx9vQVgU67FS4(whacA(tRUY0fwCExZasm6W8bz6yPxV5rb)kzcPoC6yDhRqIpwhYhpuQUQFyymUBQURMrT5OMkoTQ(XHLtNHey43(byXWeMrTAPTXiHMpzwz8mQXuhTV)GDmgmfiDAQLOJ2oZlSJA1erOLu)KXA1pR(f1VcFJECn5f2NyQzN6DZ36(x8)p



{
    ["iconSource"] = -1,
    ["xOffset"] = 80,
    ["yOffset"] = 0,
    ["anchorPoint"] = "CENTER",
    ["cooldownSwipe"] = true,
    ["cooldownEdge"] = false,
    ["actions"] = {
        ["start"] = {
        },
        ["init"] = {
        },
        ["finish"] = {
        },
    },
    ["triggers"] = {
        [1] = {
            ["trigger"] = {
                ["useName"] = true,
                ["auranames"] = {
                    [1] = "268877",
                },
                ["type"] = "aura2",
                ["ownOnly"] = true,
                ["event"] = "Health",
                ["unit"] = "player",
                ["unitExists"] = false,
                ["matchesShowOn"] = "showOnActive",
                ["spellIds"] = {
                },
                ["subeventSuffix"] = "_CAST_START",
                ["subeventPrefix"] = "SPELL",
                ["names"] = {
                },
                ["debuffType"] = "HELPFUL",
            },
            ["untrigger"] = {
            },
        },
        ["activeTriggerMode"] = -10,
    },
    ["internalVersion"] = 66,
    ["keepAspectRatio"] = false,
    ["animation"] = {
        ["start"] = {
            ["type"] = "none",
            ["easeStrength"] = 3,
            ["duration_type"] = "seconds",
            ["easeType"] = "none",
        },
        ["main"] = {
            ["type"] = "none",
            ["easeStrength"] = 3,
            ["duration_type"] = "seconds",
            ["easeType"] = "none",
        },
        ["finish"] = {
            ["type"] = "none",
            ["easeStrength"] = 3,
            ["duration_type"] = "seconds",
            ["easeType"] = "none",
        },
    },
    ["desaturate"] = false,
    ["subRegions"] = {
        [1] = {
            ["type"] = "subbackground",
        },
        [2] = {
            ["text_shadowXOffset"] = 0,
            ["text_text_format_s_format"] = "none",
            ["text_text"] = "%p",
            ["text_shadowColor"] = {
                [1] = 0,
                [2] = 0,
                [3] = 0,
                [4] = 1,
            },
            ["text_selfPoint"] = "AUTO",
            ["text_automaticWidth"] = "Auto",
            ["text_fixedWidth"] = 64,
            ["anchorYOffset"] = 0,
            ["text_justify"] = "CENTER",
            ["rotateText"] = "NONE",
            ["text_text_format_p_time_legacy_floor"] = false,
            ["type"] = "subtext",
            ["text_text_format_p_time_dynamic_threshold"] = 60,
            ["text_color"] = {
                [1] = 1,
                [2] = 1,
                [3] = 1,
                [4] = 1,
            },
            ["text_font"] = "Friz Quadrata TT",
            ["text_text_format_p_format"] = "timed",
            ["text_shadowYOffset"] = 0,
            ["text_text_format_p_time_mod_rate"] = true,
            ["text_wordWrap"] = "WordWrap",
            ["text_fontType"] = "OUTLINE",
            ["text_anchorPoint"] = "OUTER_TOP",
            ["text_text_format_p_time_format"] = 0,
            ["text_visible"] = false,
            ["text_fontSize"] = 22,
            ["anchorXOffset"] = 0,
            ["text_text_format_p_time_precision"] = 1,
        },
        [3] = {
            ["glowFrequency"] = 0.25,
            ["type"] = "subglow",
            ["useGlowColor"] = false,
            ["glowType"] = "buttonOverlay",
            ["glowLength"] = 10,
            ["glowYOffset"] = 0,
            ["glowColor"] = {
                [1] = 1,
                [2] = 1,
                [3] = 1,
                [4] = 1,
            },
            ["glowDuration"] = 1,
            ["glowXOffset"] = 0,
            ["glow"] = false,
            ["glowScale"] = 1,
            ["glowThickness"] = 1,
            ["glowLines"] = 8,
            ["glowBorder"] = false,
        },
    },
    ["height"] = 45,
    ["load"] = {
        ["use_talent"] = false,
        ["class_and_spec"] = {
            ["single"] = 253,
            ["multi"] = {
            },
        },
        ["talent"] = {
            ["multi"] = {
                [100670] = true,
            },
        },
        ["use_class_and_spec"] = true,
        ["class"] = {
            ["multi"] = {
            },
        },
        ["spec"] = {
            ["multi"] = {
            },
        },
        ["size"] = {
            ["multi"] = {
            },
        },
    },
    ["regionType"] = "icon",
    ["cooldown"] = true,
    ["parent"] = "BM shit",
    ["icon"] = true,
    ["selfPoint"] = "CENTER",
    ["zoom"] = 0.25,
    ["cooldownTextDisabled"] = false,
    ["alpha"] = 1,
    ["config"] = {
    },
    ["id"] = "Удар зверя",
    ["frameStrata"] = 1,
    ["useCooldownModRate"] = true,
    ["anchorFrameType"] = "SCREEN",
    ["width"] = 45,
    ["uid"] = "xadnv4z67gA",
    ["inverse"] = false,
    ["color"] = {
        [1] = 1,
        [2] = 1,
        [3] = 1,
        [4] = 1,
    },
    ["conditions"] = {
        [1] = {
            ["check"] = {
                ["trigger"] = 1,
                ["variable"] = "expirationTime",
                ["op"] = "==",
                ["value"] = "3",
            },
            ["changes"] = {
                [1] = {
                    ["value"] = {
                        ["sound_type"] = "Play",
                        ["sound"] = "Interface\\\\AddOns\\\\WeakAuras\\\\Media\\\\Sounds\\\\KittenMeow.ogg",
                        ["sound_channel"] = "Dialog",
                    },
                    ["property"] = "sound",
                },
                [2] = {
                    ["value"] = 60,
                    ["property"] = "height",
                },
                [3] = {
                    ["value"] = {
                        ["glow_frame_type"] = "FRAMESELECTOR",
                        ["glow_frame"] = "ActionButton4",
                        ["glow_type"] = "Proc",
                        ["glow_action"] = "show",
                        ["glow_startAnim"] = true,
                    },
                    ["property"] = "glowexternal",
                },
                [4] = {
                    ["value"] = 60,
                    ["property"] = "width",
                },
                [5] = {
                },
            },
        },
        [2] = {
            ["check"] = {
                ["trigger"] = 1,
                ["variable"] = "expirationTime",
                ["value"] = "2",
                ["op"] = "==",
            },
            ["changes"] = {
                [1] = {
                    ["value"] = {
                        ["sound_type"] = "Play",
                        ["sound"] = "Interface\\\\AddOns\\\\WeakAuras\\\\Media\\\\Sounds\\\\KittenMeow.ogg",
                        ["sound_channel"] = "Dialog",
                    },
                    ["property"] = "sound",
                },
                [2] = {
                    ["value"] = 60,
                    ["property"] = "height",
                },
                [3] = {
                    ["value"] = {
                        ["glow_frame_type"] = "FRAMESELECTOR",
                        ["glow_action"] = "show",
                        ["glow_type"] = "Proc",
                        ["glow_frame"] = "ActionButton4",
                        ["glow_startAnim"] = true,
                    },
                    ["property"] = "glowexternal",
                },
                [4] = {
                    ["value"] = 60,
                    ["property"] = "width",
                },
                [5] = {
                },
            },
        },
        [3] = {
            ["check"] = {
                ["trigger"] = -2,
                ["op"] = ">",
                ["variable"] = "AND",
                ["checks"] = {
                    [1] = {
                        ["trigger"] = 1,
                        ["variable"] = "expirationTime",
                        ["op"] = ">",
                        ["value"] = "3",
                    },
                },
            },
            ["changes"] = {
                [1] = {
                    ["value"] = {
                        ["glow_frame_type"] = "FRAMESELECTOR",
                        ["glow_type"] = "Proc",
                        ["glow_action"] = "hide",
                        ["glow_frame"] = "ActionButton4",
                    },
                    ["property"] = "glowexternal",
                },
                [2] = {
                },
            },
        },
        [4] = {
            ["check"] = {
                ["trigger"] = -2,
                ["op"] = ">",
                ["variable"] = "AND",
                ["checks"] = {
                    [1] = {
                        ["trigger"] = 1,
                        ["variable"] = "show",
                        ["value"] = 0,
                        ["op"] = ">",
                    },
                },
            },
            ["changes"] = {
                [1] = {
                    ["value"] = {
                        ["glow_frame_type"] = "FRAMESELECTOR",
                        ["glow_frame"] = "ActionButton4",
                        ["glow_action"] = "hide",
                    },
                    ["property"] = "glowexternal",
                },
            },
        },
    },
    ["information"] = {
    },
    ["authorOptions"] = {
    },
}
@nookthanx nookthanx added the 🐛 Bug This is a problem with WeakAuras. label Sep 30, 2023
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Sep 30, 2023
@mrbuds
Copy link
Contributor

mrbuds commented Sep 30, 2023

This is not a bug, let me explain

Condition 4: trigger 1; Aura Active = false => hide glow
conditions are not evaluated when the aura is not active, so this condition is never run

Condition 3: trigger 1; Aura Remaining Duration > 3 => hide glow
when an aura apply a glow, a key for this glow is saved internally for this clone/state
this key is lost when aura is not active
this condition is evaluated before any glow is applied and current state of the aura doesn't know about previously applied glows

This is why there is an option in action tab called Hide Glows applied by this aura, this is evaluated when aura hide, before glow's key is lost

@mrbuds mrbuds closed this as completed Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

No branches or pull requests

2 participants