Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key binding display - header no longer shown #4659

Closed
2 tasks done
mbattersby opened this issue Oct 17, 2023 · 2 comments
Closed
2 tasks done

Key binding display - header no longer shown #4659

mbattersby opened this issue Oct 17, 2023 · 2 comments
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@mbattersby
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

Looks like header= in Bindings.xml is now non-functional (on retail), so the keybindings are not obviously part of WeakAuras:

image

Fix is probably to remove header= and set category="BINDING_HEADER_WEAKAURAS", but I don't know how this interacts with classic/classic_era. Probably very poorly I suspect.

It seems like with DF launch using anything other than category="ADDONS" caused taint but it looks to have been fixed.

See: Stanzilla/WoWUIBugs#305

WeakAuras Version

WeakAuras 5.8.3

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

US/NA

Tested with only WeakAuras

  • Yes

Lua Error

N/A

Reproduction Steps

  1. Open the keybindings
  2. Observe

Last Good Version

I assume it's been this way since DF launched

Screenshots

See above.

Export String

N/A
@mbattersby mbattersby added the 🐛 Bug This is a problem with WeakAuras. label Oct 17, 2023
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Oct 17, 2023
@mbattersby
Copy link
Author

Also: Stanzilla/WoWUIBugs#284 for the taint fix

@mrbuds
Copy link
Contributor

mrbuds commented Oct 17, 2023

Thanks for bringing it up, the change you propose works for the 3 released versions of the game

mrbuds added a commit to mrbuds/WeakAuras2 that referenced this issue Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

No branches or pull requests

2 participants