Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemID Loading Condition #4663

Closed
Wraiyth1 opened this issue Oct 20, 2023 · 0 comments
Closed

ItemID Loading Condition #4663

Wraiyth1 opened this issue Oct 20, 2023 · 0 comments
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.

Comments

@Wraiyth1
Copy link

Is your feature request related to a problem? Please describe.

Up until recently I've been using a trinket tracking WA that only shows trinkets that have a cooldown, and have been able to add the ItemID of any trinkets with a CD that I didn't want to track to the NOT Item BonusID Equipped load condition.

This was identified as a bug and fixed a few days ago because that field shouldn't have worked for ItemID as per #4653 , which means I can now see the trinkets in my WA that I do not wish to track (in this case Ominous Chromatic Essence and similar non-combat cooldowns)

Describe the solution you'd like

I feel the best solution(s) would be to either add ItemID back to the Bonus ID field with a clarified tooltip, create an additional NOT equipped field for Item ID specifically, or a NOT Item Equipped field could work fine too in my case. Just any way of NOT loading a WA based on other Item criteria (name, ID) in addition to bonus ID would be perfect.

Describe alternatives you've considered

I was able to fix my issue by finding a community fork of the IDTip addon to get the Bonus IDs so there is a workable (albeit a little more convoluted) solution.

This feature is not strictly necessary for my specific case, but if someone were less inclined to use a tooltip addon or similar, Item ID is the simplest one to find when searching the item on wowhead (in the address bar) or if there are equippable items that don't have bonus IDs - I have no idea - this would resolve any potential for issues there too.

@Wraiyth1 Wraiyth1 added the 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. label Oct 20, 2023
mrbuds added a commit to mrbuds/WeakAuras2 that referenced this issue Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.
Projects
None yet
Development

No branches or pull requests

1 participant