Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell in range trigger does not work with Mend Pet as intended #4828

Closed
2 tasks done
JP-Satrio opened this issue Jan 24, 2024 · 2 comments
Closed
2 tasks done

Spell in range trigger does not work with Mend Pet as intended #4828

JP-Satrio opened this issue Jan 24, 2024 · 2 comments
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@JP-Satrio
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

I tried to create a heal pet! warning (text), and adding a range based color change, to notify the user if they're out of the spell's range. The trigger was pet health % and spell cooldown/charges/count with a condition of spell in range false, but it did not work at all. I tested to move in/out of ranged attack range, but with no success either. With Lisonna's help in the WA discord channel, we got clarified that the weakaura worked if the pet was targeted, but since it should be working without targeting the pet, this specific spell (and probably Health funnel as well) should always be defaulted to pet, without requiring a target.

WeakAuras Version

WeakAuras 5.9.2

World of Warcraft Flavor

Classic

World of Warcraft Region

EU

Tested with only WeakAuras

  • Yes

Lua Error

No response

Reproduction Steps

as mentioned above
text aura
trigger pet health %<20
trigger spell cooldown/charges/count
condition spell in range -> false : color change

Last Good Version

No response

Screenshots

No response

Export String

No response

@JP-Satrio JP-Satrio added the 🐛 Bug This is a problem with WeakAuras. label Jan 24, 2024
@JP-Satrio JP-Satrio changed the title Spell in range trigger does not work with Mend Pet Spell in range trigger does not work with Mend Pet as intended Jan 24, 2024
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Jan 24, 2024
@emptyrivers
Copy link
Contributor

It's a bit strange to presume so much about how WeakAuras is 'supposed' to work, I think. Mend pet has a 45 yard range, and indeed as you describe the range condition hinges on whether or not you're in range of your target. For more than 99% of all spells that you would ever track, this is sufficient. And for the rare exception like mend pet, we're not really in the business of creating special magic edge cases (that's your job as the user 🙂).

@JP-Satrio
Copy link
Author

JP-Satrio commented Jan 25, 2024

Well... OK. I see. Actually Mend pet really has a 45 yd range as being said - but only in SoD https://www.wowhead.com/spell=136/mend-pet in contrary to the classic version, which has a shorter, 20 yd range https://www.wowhead.com/classic/spell=136/mend-pet.
The users are, in fact able to create workarounds, and the members of the community is helping each other, but as one might expect, the spell in range condition might trigger according to each and every specific spell. Might it not? As I could notice, it changes according to talent specialization, so other hunter spells range trigger works properly. With that being said, I thought it would be a good idea to bring attention to this phenomenon with this specific spell (and probably Health funnel - haven't tested that one tho). It started as a bug report, but now I think it's more like a feature request. I really don't want to force anything, so if you, as a dev, say that it works as intended, I can totally understand that and accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

No branches or pull requests

2 participants