Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show spell name in brackets when a spell id is used in the spell name field of a combat log trigger #4829

Closed
calummitchell opened this issue Jan 25, 2024 · 3 comments
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.

Comments

@calummitchell
Copy link

Is your feature request related to a problem? Please describe.
Recently I've seen a number of recommendations on the weakaura discord to use a spell id in the spell name field of a trigger rather than use the spell id field. When you do this in an Aura trigger it helpfully automatically shows you the spell name in brackets after the spell id. It doesn't currently do this for Combat Log triggers though. Probably just an oversight.

Describe the solution you'd like
Show spell name in brackets when a spell id is used in the spell name field of a combat log trigger similar to Aura triggers

Describe alternatives you've considered
n/a

Additional context
Add any other context or screenshots about the feature request here.
combatlogtrigger

@calummitchell calummitchell added the 🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature. label Jan 25, 2024
@InfusOnWoW
Copy link
Contributor

That's the spell name field, which matches only against the name. The Spell Id field above matches against the id. There are subtle technical reasons why different triggers work sligthly differently.

@calummitchell
Copy link
Author

Ok just to make sure I understand the situation, could you tell me if the following is true?

  1. Using a spell id in the spell name field of an Aura trigger is supported. It shows you the spell name it will match against in brackets. In fact it's recommended to do this over using the spell id field.

  2. For subtle technical reasons this isn't supported for Combat Log triggers. Which is why the spell name field isn't shown in brackets. I shouldn't be using spell ids in the spell name field of Combat Log triggers.

fyi using a spell id in the spell name field of a Combat Log trigger worked for the few examples I tried (cast success, aura applied), but I'm assuming not everything would work.

@InfusOnWoW
Copy link
Contributor

Oh you are right, the combat log trigger actually supports ids in the name field, then you are right that the ui should reflect that.

@InfusOnWoW InfusOnWoW reopened this Jan 25, 2024
InfusOnWoW added a commit to InfusOnWoW/WeakAuras2 that referenced this issue Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Feature Request This is a request for a new feature, or an expansion of an existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants