Defining a Spell Name in a Combat Log Trigger then switching the Trigger's Type to Spell causes a lua error and strange UI behavior

[mhamwey]

Is there an existing issue for this?

• I have searched the existing open and closed issues.

Description

When I specify a Spell Name for a Combat Log Trigger, then update the Trigger's type from Combat Log to Spell, I expect WeakAuras to show the options for a Spell Trigger. Instead, WeakAuras throws a lua error, and the WeakAuras Options UI stops working properly for the Aura in question.

In this broken state, WeakAuras will throw the same lua error every time the affected Aura's options are opened or changed. Adding, deleting, or moving Triggers or Conditions for the affected Aura are not reflected by the WeakAuras Options UI until the offending Trigger is deleted or its Type is changed.

WeakAuras can be restored to a fully working state by deleting the offending Aura, deleting the offending Trigger, or modifying the Type of the offending Trigger.

WeakAuras Version

WeakAuras 5.17.5

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

US/NA

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

1x bad argument #1 to '?' (Usage: local name = C_Spell.GetSpellName(spellIdentifier))
[string "=[C]"]: in function `GetSpellName'
[string "@WeakAuras/GenericTrigger.lua"]:3445: in function `GetEffectiveSpellId'
[string "@WeakAuras/Prototypes.lua"]:2252: in function `GetNameAndIcon'
[string "@WeakAuras/GenericTrigger.lua"]:1064: in function <WeakAuras/GenericTrigger.lua:1050>
[string "@WeakAuras/GenericTrigger.lua"]:1100: in function `CreateFakeStates'
[string "@WeakAuras/WeakAuras.lua"]:4678: in function `UpdateFakeStatesFor'
[string "@WeakAuras/WeakAuras.lua"]:4654: in function `FakeStatesFor'
[string "@WeakAuras/WeakAuras.lua"]:3268: in function <WeakAuras/WeakAuras.lua:3119>
[string "@WeakAuras/WeakAuras.lua"]:3292: in function `Add'
[string "@WeakAurasOptions/CommonOptions.lua"]:1733: in function <WeakAurasOptions/CommonOptions.lua:1725>
[string "=[C]"]: ?
[string "@WeakAurasOptions/Libs/AceConfig-3.0-3/AceConfigDialog-3.0-87/AceConfigDialog-3.0.lua"]:45: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:43>
[string "@WeakAurasOptions/Libs/AceConfig-3.0-3/AceConfigDialog-3.0-87/AceConfigDialog-3.0.lua"]:839: in function <...nfig-3.0/AceConfigDialog-3.0/AceConfigDialog-3.0.lua:661>
[string "=[C]"]: ?
[string "@WeakAurasOptions/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:66: in function <...dOns/WeakAurasOptions/Libs/AceGUI-3.0/AceGUI-3.0.lua:64>
[string "@WeakAurasOptions/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:300: in function `Fire'
[string "@WeakAurasOptions/Libs/AceGUI-3.0-41/widgets/AceGUIWidget-DropDown.lua"]:432: in function <...ns/Libs/AceGUI-3.0/widgets/AceGUIWidget-DropDown.lua:423>
[string "=[C]"]: ?
[string "@WeakAurasOptions/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:66: in function <...dOns/WeakAurasOptions/Libs/AceGUI-3.0/AceGUI-3.0.lua:64>
[string "@WeakAurasOptions/Libs/AceGUI-3.0-41/AceGUI-3.0.lua"]:300: in function `Fire'
[string "@WeakAurasOptions/Libs/AceGUI-3.0-41/widgets/AceGUIWidget-DropDown-Items.lua"]:351: in function <...s/AceGUI-3.0/widgets/AceGUIWidget-DropDown-Items.lua:341>

Locals:
(*temporary) = "bad argument #1 to '?' (Usage: local name = C_Spell.GetSpellName(spellIdentifier))"

Reproduction Steps

1. Open WeakAura's Options.
2. Select an existing Aura, or create a new one (the type does not matter as long as it is not a Group/Dynamic Group).
3. Open the Trigger tab.
4. Expand the options for any trigger (it does not matter which trigger) by clicking the arrow next to its name. If the options are already expanded for you, simply go to the next step.
5. Change the Type dropdown to "Combat Log", if it isn't already.
6. Change the Subevent dropdown to "Spell", if it isn't already.
7. Check the box next to Spell Name.
8. Enter a valid spell name (like Rip) into the Spell Name text box, then press Okay.
9. Change the Type dropdown to "Spell".
10. Observe the resulting lua error and strange UI behavior.

Last Good Version

No response

Screenshots

Export String

No response

Bisector Report

No response