Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Boss Mod Stage (Event)" Rounding error. #5538

Closed
1 task done
fisken1991 opened this issue Nov 19, 2024 · 2 comments
Closed
1 task done

"Boss Mod Stage (Event)" Rounding error. #5538

fisken1991 opened this issue Nov 19, 2024 · 2 comments
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@fisken1991
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

I encountered an issue with the Boss Mod Stage (Event) that triggers a fake stage 3 event when bigwigs send the stage 2.5 event. This rounding up made my stage 3 weakauras trigger early and twice. The second when it should but the first one from stage 2.5 was wrong

image
image

WeakAuras Version

Weakauras 5.17.5

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

EU

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

No response

Reproduction Steps

Play The Silken Court in Nerub-ar Palace on Mythic difficulity.
Set up a trigger with Type "Other Addons", "Boss Mod Stage(Event)" as you can in the in the picture provided.
When you enter intermission 2. Big wigs will send a Stage 2.5 event comfirmed by Bigwigs discord(check the picture provided). This will trigger the Stage 3 event aura incorrectly. Maybe due to rounding up as suggested by the bigwigs community.

Last Good Version

No response

Screenshots

No response

Export String

No response

Bisector Report

No response

@fisken1991 fisken1991 added the 🐛 Bug This is a problem with WeakAuras. label Nov 19, 2024
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Nov 19, 2024
@fisken1991 fisken1991 changed the title " Boss Mod Stage (Event)" Rounding error. "Boss Mod Stage (Event)" Rounding error. Nov 19, 2024
@mrbuds
Copy link
Contributor

mrbuds commented Nov 21, 2024

Are you 100% sure you don't have a copy of same aura without the stage filter?

TheSilkenCourt.lua call self:SetStage(3) on mod:SpikeStormRemoved when args.amount == 0

boss:SetStage(stage) call callback BigWigs_SetStage

on BigWigs_SetStage WeakAuras set self.currentStage to stage and call WeakAuras.ScanEvents("BossMod_SetStage")

on BossMod_SetStage internal event Boss Mod Stage trigger set stage value from Private.ExecEnv.BossMods.Generic:GetStage() which returns self.currentStage

There is no rounding anywhere, or i missed it

@InfusOnWoW
Copy link
Contributor

I just checked that:
a) The stage code for LFR and mythic is identical
b) In LFR: Checked with prints when TheSilkenCourt.lua sets the variuous stages
c) Checked what WA receives
d) Checked an aura for stage 3

And also
e) Checked all code in WA that handles stages

This is almost certainly a user error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

No branches or pull requests

3 participants