Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting word doesn't create an undo step if it is a first action [CKEditor 4] #2

Open
f1ames opened this issue Aug 2, 2019 · 5 comments

Comments

@f1ames
Copy link

f1ames commented Aug 2, 2019

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Go to https://webspellchecker.com/wsc-proofreader/#proofreader-ckeditor4.
  2. Correct any word via WProofreader menu/panel.

Expected result

The change is possible to undo.

Actual result

Undo is still inactive and it activates after more changes are made (e.g. typing). If correction wasn't the first action in the editor it works fine, so it is only an issue when corrections are first actions in the editor.

wpr 1

Other details

Tested on Chrome with CKEditor 4.

It works fine in CKEditor 5, so it depends on the editor architecture and how it reacts to external DOM changes.

@jshaptala
Copy link
Member

For replace functionality we use an internal browser mechanism document.execCommand('insertText', false, 'text'). Somehow CKEditor 4 doesn't react on these text changes. We use similar mechanism as the native browser spellcheck uses for replace.

Are able to investigate this problem on your side in CKEditor 4 implementation?

Or if it is critical and impossible to make changes in your current implementation of CKEditor 4, alternatively, we would suggest to use classic SCAYT and WSC dialog plugins which are tailed for CKEditor 4.

@f1ames
Copy link
Author

f1ames commented Aug 19, 2019

Thanks for the insights @wsc-julia-shaptala. So it looks like CKEditor 4 issue, we will try to investigate on our side what's going on there👌

@jshaptala
Copy link
Member

@f1ames Thank you for confirming this. It seems that we should wait for the feedback from your side regarding this matter. I will keep this one open until we have news from your end.

@f1ames
Copy link
Author

f1ames commented Aug 21, 2019

I can confirm this is indeed CKEditor 4 issue and it also concerns native spellchecking - ckeditor/ckeditor4#2384.

We may leave this issue open for reference and close it when CKEditor 4 issue gets resolved or just close it as it will be handled entirely on our side.

@jshaptala
Copy link
Member

Let's keep this one open for now. As soon as you resolve the issue on your end, we will be able to return to this one and close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants