Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change.DoesNotExist: Change matching query does not exist. #13317

Closed
sentry-io bot opened this issue Dec 17, 2024 · 3 comments · Fixed by #13332
Closed

Change.DoesNotExist: Change matching query does not exist. #13317

sentry-io bot opened this issue Dec 17, 2024 · 3 comments · Fixed by #13332
Assignees
Labels
bug Something is broken.
Milestone

Comments

@sentry-io
Copy link

sentry-io bot commented Dec 17, 2024

Sentry Issue: WEBLATE-1NJC

Change.DoesNotExist: Change matching query does not exist.
(4 additional frame(s) were not displayed)
...
  File "weblate/trans/views/edit.py", line 669, in translate
    response = handle_suggestions(request, unit, this_unit_url, next_unit_url)
  File "weblate/trans/views/edit.py", line 585, in handle_suggestions
    old=suggestion.change_set.latest("timestamp").old,

This seems regression caused by #13214

@sentry-io sentry-io bot added the bug Something is broken. label Dec 17, 2024
@nijel nijel added this to the 5.9.2 milestone Dec 17, 2024
@nijel
Copy link
Member

nijel commented Dec 18, 2024

@gersona This is a five-year-old suggestion that didn't yet create matching Change objects. The code should deal with such a situation. Would it be possible to do it without relying on change objects?

@gersona
Copy link
Contributor

gersona commented Dec 18, 2024

oh right, that makes sense. I was starting to investigate how on earth did the Suggestion creation stop before the Change object was created.
Yeah, the unit.target could be used as well . As the suggestion is always relative to the current target, it doesn't matter if it has been updated multiple times since the suggestion was first added

Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants