Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pt-PT language - keep pt and pt-BR [Updated] #13336

Closed
horus68 opened this issue Dec 18, 2024 · 6 comments
Closed

Remove pt-PT language - keep pt and pt-BR [Updated] #13336

horus68 opened this issue Dec 18, 2024 · 6 comments
Assignees
Labels
enhancement Adding or requesting a new feature.
Milestone

Comments

@horus68
Copy link

horus68 commented Dec 18, 2024

Describe the problem

There is no need to have 2 "European portuguese" languages for the Weblate project
https://hosted.weblate.org/projects/weblate/
This is causing issues in consistence and extra work!

Describe the solution you would like

remove the "pt" language . The pt-PT language should be used instead.
https://hosted.weblate.org/projects/weblate/-/pt/

Keep those:
pt_PT (European portuguese)
https://hosted.weblate.org/projects/weblate/-/pt_PT/

pt_BR (Portuguese - Brazil)
https://hosted.weblate.org/projects/weblate/-/pt_BR/

Describe alternatives you have considered

No response

Screenshots

No response

Additional context

The code "pt" is only used when there is no more portuguese flavours (usually in new projects) and it referes to the Portuguese (European) reference.
A translation project should have 2 portuguese flavours:
the main pt_PT (European portuguese / Portugal) and a pt_BR (Portuguese - Brazil)

@nijel
Copy link
Member

nijel commented Dec 18, 2024

If we're going to remove something, then it should be pt_PT. pt is needed as fallback when the user has configured Portuguese in the browser. Presently, pt_PT and pt differ considerably, so I'm not really in position to remove either of these without knowledge of the language.

Looking at https://en.wikipedia.org/wiki/Portuguese_language#Lusophone_countries, pt still covers tens of millions of speakers outside pt_PT and pt_BR.

@horus68
Copy link
Author

horus68 commented Dec 18, 2024

I'm a pt-PT portuguese native translator.
pt-PT it's the proper code for Portuguese (European), the origin of the portuguese language, and the default for any portuguese speaking country, except for Brazil (pt-BR) that has a quite different language use. All other countries on that "Lusophone countries" list just uses the pt_PT version.

"pt" it's only used when a system doesn't have pt-BR translation (from an initial bad setup for sure). Has soon as pt-BR comes along ()

The weblate pt version has been also translated by translators from Portugal (and some Brazilian users by mistake).
What have we now? two different versions none of them a perfect one!
Has for now, pt-PT has a better translation in Weblate!

So, for me the pt-PT version will be the one I will be involved with, even if I get wrong suggestions form the "pt" version

@nijel
Copy link
Member

nijel commented Dec 19, 2024

In case pt-PT is better, we should rename it to pt (after dropping that one). The reason is how language selection works in browsers as described before.

@rffontenelle
Copy link
Contributor

rffontenelle commented Dec 23, 2024

Brazilian Portuguese translator here. I'm used to see pt as European Portuguese. Since it is a fallback locale (for pt_BR and any other variant), it will work fine for systems set with pt-PT locale.

The current translation differences between pt and pt-PT should be considered and fixed before dropping the variant. For instance, a Brazilian translation in pt (wrong) should be replaced with the translation from pt-PT if any. This might take some time and effort, so my suggestion is to do some coordination e.g. checklist, talking with other active Portuguese translators so that everyone is on the same page, etc

@horus68 horus68 changed the title Remove pt language - keep pt-PT and pt-BR Remove pt-PT language - keep pt and pt-BR [Updated] Dec 27, 2024
@horus68
Copy link
Author

horus68 commented Dec 27, 2024

@nijel To keep pt and remove pt-PT, I have reviewed all strings translated in pt files that had been translated differently in pt-PT so that nothing is lost when pt-PT is removed. It is now safe to delete the pt-PT language!

I also changed the title of this issue.

When the pt-PT language is removed, I will make new translations and fixes in the pt language files

@nijel nijel added this to the 5.10 milestone Dec 27, 2024
@nijel nijel self-assigned this Dec 27, 2024
@nijel nijel added the enhancement Adding or requesting a new feature. label Dec 27, 2024
@nijel nijel closed this as completed in 4d46cca Dec 27, 2024
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants