-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oauth endpoint #4
Comments
@danielsz: looks like that get request is unnecessary. we'll get rid of it. thanks for pointing it out! |
Only unnecessary if you don't plan to support unauthenticated users coming from the app (as opposed to users from the app center who are already authenticated). |
Not sure what you mean; the call removed in $5 wasn't doing a whole lot (since it didn't GET with anything), so it was effectively a check to see "does the server exist". |
True. I didn't mean that this line alone was handling the case of unauthenticated users, just that it would be handy to add support for that use case. Sorry for the misunderstanding. |
Compared with the php example application, the Oauth endpoints do not match.
https://github.com/Weebly/node-webhook-client/blob/master/app/oauth-router.js#L45
vs.
https://github.com/Weebly/weebly-client-php/blob/0.1/src/Weebly/WeeblyClient.php#L119
The text was updated successfully, but these errors were encountered: