Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth endpoint #4

Open
danielsz opened this issue Jul 20, 2016 · 4 comments
Open

Oauth endpoint #4

danielsz opened this issue Jul 20, 2016 · 4 comments

Comments

@danielsz
Copy link

Compared with the php example application, the Oauth endpoints do not match.

https://github.com/Weebly/node-webhook-client/blob/master/app/oauth-router.js#L45

https://api.weebly.com/app-center/authorize

vs.

https://github.com/Weebly/weebly-client-php/blob/0.1/src/Weebly/WeeblyClient.php#L119

https://www.weebly.com/app-center/oauth/authorize
@puddi
Copy link
Contributor

puddi commented Jul 20, 2016

@danielsz: looks like that get request is unnecessary. we'll get rid of it. thanks for pointing it out!

@danielsz
Copy link
Author

Only unnecessary if you don't plan to support unauthenticated users coming from the app (as opposed to users from the app center who are already authenticated).

@puddi
Copy link
Contributor

puddi commented Jul 20, 2016

Not sure what you mean; the call removed in $5 wasn't doing a whole lot (since it didn't GET with anything), so it was effectively a check to see "does the server exist".

@danielsz
Copy link
Author

True. I didn't mean that this line alone was handling the case of unauthenticated users, just that it would be handy to add support for that use case. Sorry for the misunderstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants