Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CJS interop #9

Merged
merged 5 commits into from
Aug 15, 2024
Merged

Fix CJS interop #9

merged 5 commits into from
Aug 15, 2024

Conversation

mskelton
Copy link

Was encountering some issues when using expect-axe-playwright and it seems related to broken CJS exports in this package.

@mskelton mskelton requested a review from a team as a code owner August 15, 2024 14:48
@mskelton mskelton requested a review from joephela August 15, 2024 14:48
Copy link

changeset-bot bot commented Aug 15, 2024

🦋 Changeset detected

Latest commit: 3491571

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
axe-reporter-html Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mskelton
Copy link
Author

Hey friends! 👋

Copy link

@joephela joephela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mskelton !

@mskelton
Copy link
Author

@joephela Thanks for the approval, when you get a chance to merge and cut a release, I'll make a PR in expect-axe-playwright to get it updated to the latest of this package.

@joephela
Copy link

@mskelton our github actions are not triggering from your forked branch, we are looking into it.

Try to get github actions to work.
Try to fix github actions.
@joephela joephela enabled auto-merge (squash) August 15, 2024 19:27
@joephela joephela merged commit cbcd18e into Widen:main Aug 15, 2024
5 checks passed
@joephela
Copy link

@mskelton mskelton deleted the fix-cjs-interop branch August 15, 2024 20:33
@mskelton
Copy link
Author

@joephela I'm flying home today from NYC, but I'll get it handled tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants