Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clustering_Separate #302

Open
36 of 37 tasks
HaiwangYu opened this issue Jun 13, 2024 · 1 comment
Open
36 of 37 tasks

Clustering_Separate #302

HaiwangYu opened this issue Jun 13, 2024 · 1 comment
Assignees

Comments

@HaiwangYu
Copy link
Member

HaiwangYu commented Jun 13, 2024

Based on Xin's "Clustering_graph" slides.
notes: https://www.phy.bnl.gov/bnlif/cgi-bin/private/ShowDocument?docid=369

  • JudgeSeparateDec_1
    • PCA
    • validation
  • JudgeSeparateDec_2
    • QuickHull - make Cluster::get_hull()
      • add quickhull dependent
      • Move to clus
      • validation
  • Create_graph
  • Separate_1
    • Get_furtherest_wcpoint
    • Adjust_wcpoints_parallel
      • 2DPC
        • get_closest_2d_index
    • Graph operations:
      • Dijkstra_shortest_paths
      • Cal_shortest_path
        • Return is a list of wcps points
    • Made a temporary point_cloud
      • Simple2DPointCloud
        • get_closest_2d_dis
    • Separate clusters
      • Blobs go to cluster 1
      • The rest of blobs go to cluster 2 -> separate_2 function
  • Separate_2
    • Form a local graph
    • For each connected component, create a local point cloud
    • Run connected_component to get separated clusters
  • entry function clustering_separate
  • function call for clustering_separate
    • information for dead_[uvw]_index
  • full WCP validation clustering_separate full validation #323
@HaiwangYu HaiwangYu added this to the Clustering_Separate ported milestone Jun 13, 2024
@HaiwangYu HaiwangYu changed the title Overview of Clustering_Separate Clustering_Separate Jun 18, 2024
@brettviren
Copy link
Member

I don't like a whole new quickhull sub package just to "vendor" its few source files. Can we move its contents into the new clust subpackage and then remove the emptied quickhull` sub package directory?

Also, is PAAL still going to be used? If so, can the contents of patrec likewise be moved into clus?

@HaiwangYu HaiwangYu self-assigned this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants