-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition of "logsource" values like product or category. #107
Comments
Hey @Maspital I'm guessing you're running chainsaw with the You could either extend the sigma rule to also require a specific event ID (which should cut down the number of FPs), or you could use the I don't think either of these two options will completely solve your issue, but it should reduce the number of FPs that you face. |
There is also potential to add category support to the mapping to apply 'x' filter when category 'y' is set. But this would require code enhancements. |
Yes, I'm using a modified version of Using the legacy mapping file seems like it both has a lot of duplicate entries and prevents any novel alerts from being shown because they are blocked by the manually set filters(?). Having category support like you mentioned @alexkornitzer would be a really nice and useful feature imo, but I dont know how much effort this would require on your part. |
So adding this code wise is pretty easy the challenge comes from how to extend the mapping schema in a clear way, my current thinking is something like this:
Where the |
That looks great! Assuming knowledge of Sigma rules in general, this is nice and understandable in my opinion. So this would work for whatever field may be defined within the |
Ah good spot nah I would wanna support things like name too, so it should be this:
But awesome, okay i'll see if I can do this when I get time otherwise i'll lob it at someone else :) |
Any news regarding this? :) @alexkornitzer |
This allows for overriding of poor rules as discussed in #107.
@Maspital can you give the |
This allows for overriding of poor rules as discussed in #107.
Seems to work nicely, at least for the things I tested 👍 I will try it out in more detail tomorrow |
Awesome. If it all seems fine tomorrow i'll get that merged in and released. |
I'm sure I didn't test for everything, but so far everything did what it was supposed to do. Two more things:
Both of these things are just afterthoughts, I think the new feature perfectly solves the original issue. Thank you so much for implementing it so quickly! |
Thanks for checking that all out. Right so the first one is probably not doable because I don't think I have put support in to handle nested syntax for a filter so this I don't have a ton of time at the moment so I will merge the current work, and then your two above improvements can be added at a later date. For now I will keep this issue open as a reminder. |
Hey,
I am currently using chainsaw + SIGMA to evaluate log datasets and stumbled upon the following issue:
Certain SIGMA rules produce an abnormally high number of false positives, to the point where I suspect that it just triggers on most events. The rule in question is
I think the problem is that the category in question (
file_block
) is not mapped to anything - where and how can I define this?In this example, the category should be
file_block
iff"provider_name": "Microsoft-Windows-Sysmon"
andevent_id: 27
, which would clearly identify the category.I have a similar problem for several other rules. Am I perhaps misunderstanding how certain things work?
Any help on this would be much appreciated :)
The text was updated successfully, but these errors were encountered: