Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clicking 'apply setting button' fails on device when wiz5xx < 1.0.8 #36

Open
simryang opened this issue May 7, 2024 · 0 comments
Open

clicking 'apply setting button' fails on device when wiz5xx < 1.0.8 #36

simryang opened this issue May 7, 2024 · 0 comments
Assignees
@simryang

Comments

@simryang
Copy link

simryang commented May 7, 2024

modbus protocol function is only available in WIZ5XX v1.0.8 or later.
but modbus_protocol is displayed and send wrong command on clicking 'apply setting button' when the selected device does not supported modbus(version is below 1.0.8).

  • modbus_protocol UI should be disappeared or disabled when the device is not WIZ5XX or the version is below v1.0.8
  • command of disabled modbus_protocol should not be contained when 'apply setting' button is clicked.
simryang added a commit that referenced this issue May 9, 2024
@simryang
Fix clicking apply setting failed on wiz5xx < 1.0.8 #36
c45bc60
@simryang simryang self-assigned this May 20, 2024
simryang added a commit that referenced this issue Jul 17, 2024
@simryang
Fix bugs about #36
609b6e0 
* in BOOT or UPGRADE mode
** Use boot command only
** Disable unusing tab(advanced_tab(Options), channel_tab)
* Reduce delay and timeout of tcp unicast search of each retry 6 -> 4
* Use namedtuple to specify device status and tab name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simryang simryang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simryang