Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues from the code review #5

Open
scarstens opened this issue Feb 2, 2017 · 0 comments
Open

Issues from the code review #5

scarstens opened this issue Feb 2, 2017 · 0 comments

Comments

@scarstens
Copy link
Member

License file
index file
match repo name to plugin
changelog file
change plugin meta - url to repo
doing PHP in a class file in the main plugin file
missing doc blocks
indentation issue from L33 down
doc for each action/filter in the constructor
adjust comment grammer and line length
consider moving constructor filters to load at ?? plugins_loaded
allow phpstorm to fix spacing
Line 85 change var from $v
Line 92 are we sure array has 9+ items?!
Line 74 maybe apply filters on matching site url (or not)
Line 74 STUPID LONG
LINE 74 typo in protocol
LINE 115 Apply Filter to allow other service providers
LINE 121 sort order of w/h and use of w/h
LINE 124 apply filters for cloudinary filter options
Should use abstract_plugin_base
Move filtered options into an options page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant