Radio: Deprecate 36px default size #66572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Code Quality
24 tasks
mirka
added
the
Needs Dev Note
mirka
commented
Oct 29, 2024
| @@ -158,6 +158,7 @@ export function CreateTemplatePartModalContents( { | |||
| { templatePartAreas.map( | |||
| ( { icon, label, area: value, description } ) => ( | |||
| <Radio | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
In the site editor, go to Patterns ▸ All template parts ▸ Add New Pattern button ▸ Add new template part. There should be no visual changes.
| @@ -10,9 +10,12 @@ export function maybeWarnDeprecated36pxSize( { | |||
| }: { | |||
| componentName: string; | |||
| __next40pxDefaultSize: boolean | undefined; | |||
| size: string; | |||
| size: string | undefined; | |||
There was a problem hiding this comment.
Making this explicit instead of optional (size?: string) to prevent accidental omission when passing arguments to this function.
Comment on lines
+34
to
+35
| component: | ||
| 'This component is deprecated. Use `RadioControl` or `ToggleGroupControl` instead.', |
There was a problem hiding this comment.
Adding this description so people visiting the Storybook page can also see what the alternatives are.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +33 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2124cd4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11579855301
|
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Radio: Deprecate 36px default size * Add changelog * Fix changelog Co-authored-by: mirka <[email protected]> Co-authored-by: tyxla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65751
What?
Deprecate the 36px default size on
Radio, which is a subcomponent of the deprecatedRadioGroupcomponent.Why?
Technically we could do this without a formal deprecation, since RadioGroup is already deprecated. But due to one remaining usage in the app (#66569), we haven't been able to log a deprecation warning for the component yet, meaning that many existing consumers may not even know this component is deprecated.
Given the circumstances, I think it's reasonable for the size change to have an opt-in grace period like the other components.
Testing Instructions
See Storybook for
RadioGroup.