CircularOptionPicker: Update Button sizes #67285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
mirka
commented
Nov 25, 2024
| @@ -67,8 +67,8 @@ $color-palette-circle-spacing: 12px; | |||
| .components-circular-option-picker__option { | |||
| display: inline-block; | |||
| vertical-align: top; | |||
| height: 100%; | |||
| width: 100%; | |||
| height: 100% !important; | |||
There was a problem hiding this comment.
Unfortunate override. Needs some kind of unstyled Button variant.
There was a problem hiding this comment.
Yeah, quite a bummer with these overrides. I think it would make sense to explore an unstyled variant at some point. Perhaps opening an issue is a good first step to keep it documented?
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
commented
Nov 25, 2024
| @@ -47,6 +47,7 @@ export function ButtonAction( { | |||
| }: WordPressComponentProps< ButtonAsButtonProps, 'button', false > ) { | |||
| return ( | |||
| <Button | |||
| __next40pxDefaultSize | |||
There was a problem hiding this comment.
The other Button instance in this file doesn't need the prop because it is the link variant.
|
Size Change: +13 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Nov 26, 2024
| @@ -67,8 +67,8 @@ $color-palette-circle-spacing: 12px; | |||
| .components-circular-option-picker__option { | |||
| display: inline-block; | |||
| vertical-align: top; | |||
| height: 100%; | |||
| width: 100%; | |||
| height: 100% !important; | |||
There was a problem hiding this comment.
Yeah, quite a bummer with these overrides. I think it would make sense to explore an unstyled variant at some point. Perhaps opening an issue is a good first step to keep it documented?
|
Flaky tests detected in aa80495. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12034833965
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for #65751
What?
Update
Buttonsizes inCircularOptionPickerso they are ready for the 40px default size.Testing Instructions
See the Storybook stories for CircularOptionPicker. There should be no visual changes except for the size of the Clear button in the "With Button Action" story.