From 7ce6982bf9d969a92d27d7197fdcefab4eb6a1c6 Mon Sep 17 00:00:00 2001
From: Javier Casares <javier@casares.org>
Date: Wed, 7 Feb 2024 08:08:24 +0100
Subject: [PATCH 1/4] fix

---
 README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.md b/README.md
index beb752d..046dfad 100644
--- a/README.md
+++ b/README.md
@@ -53,7 +53,7 @@ cat ~/.ssh/id_rsa | base64 --wrap=0
 cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys
 ```
 
-Use a more complex SSH connection process by creating a SSH alias:
+Use a more complex SSH connection process by creating an SSH alias:
 
 ```bash
 # 1. Add the following to ~/.ssh/config to create a 'wpt' alias

From 87cfd71496d7ce15e92311f9356974c90a5a1678 Mon Sep 17 00:00:00 2001
From: Javier Casares <javier@casares.org>
Date: Wed, 7 Feb 2024 08:09:30 +0100
Subject: [PATCH 2/4] Improve PHPDoc

---
 functions.php | 152 ++++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 124 insertions(+), 28 deletions(-)

diff --git a/functions.php b/functions.php
index 6a074de..105714e 100644
--- a/functions.php
+++ b/functions.php
@@ -1,11 +1,20 @@
 <?php
-
-/**
- * Utility functions for the test runner.
- */
-
 /**
- * Check for required environment variables.
+ * Validates the presence of essential environment variables necessary for the application to run correctly.
+ * Specifically checks for variables related to directories and database configuration. It also ensures that
+ * the test and preparation directories are the same when running locally without SSH connection requirements.
+ *
+ * This function will issue error messages through `error_message()` for any missing environment variables
+ * and logs a message upon successful validation of all required variables.
+ *
+ * @param bool $check_db Optional. Whether to include database-related environment variables in the check. Defaults to true.
+ *                       If set to false, database variables (prefixed with 'WPT_DB_') are not checked.
+ *
+ * @return void This function does not return a value but will halt execution if any required environment variable is missing.
+ *
+ * @uses getenv() to retrieve environment variable values.
+ * @uses error_message() to display error messages for missing variables.
+ * @uses log_message() to log a success message when all checks pass.
  */
 function check_required_env( $check_db = true ) {
 
@@ -35,9 +44,22 @@ function check_required_env( $check_db = true ) {
 }
 
 /**
- * Perform some number of shell operations
+ * Executes a series of shell commands provided in the operations array. Each operation is logged before execution.
+ * If any command fails (indicated by a non-zero return code), an error message is displayed. This function is
+ * useful for automating batch shell tasks within a PHP script, with error handling for each operation.
+ *
+ * @param array $operations An array of shell commands (strings) to be executed. Each command should be
+ *                          a valid shell command and properly escaped for safety. The commands are executed
+ *                          in the order they appear in the array.
  *
- * @param array $operations
+ * @return void This function does not return a value. However, it will output the result of each shell command
+ *              to the standard output and log the execution. It will also halt on the first command that fails,
+ *              displaying an error message.
+ *
+ * @uses log_message() to log each operation before execution. This can be used for debugging or auditing purposes.
+ * @uses passthru() to execute the shell command, which provides direct output to the browser. Be aware that using
+ *      this function with untrusted input can lead to security vulnerabilities, such as command injection attacks.
+ * @uses error_message() to display an error message if a shell command fails. The execution stops at the first failure.
  */
 function perform_operations( $operations ) {
 	foreach( $operations as $operation ) {
@@ -50,18 +72,39 @@ function perform_operations( $operations ) {
 }
 
 /**
- * Log a message to STDOUT
+ * Writes a message followed by a newline to the standard output (STDOUT). This function is commonly used for logging purposes,
+ * providing feedback during script execution, or debugging. The message is appended with the PHP end-of-line constant (PHP_EOL)
+ * to ensure proper line breaks on different operating systems.
+ *
+ * @param string $message The message to be logged. This should be a string, and it will be output exactly as provided,
+ *                        followed by a system-specific newline character.
+ *
+ * @return void This function does not return a value. It directly writes the message to STDOUT, which is typically
+ *              visible in the console or terminal where the PHP script is executed.
  *
- * @param string $message
+ * @uses fwrite() to write the message to STDOUT. This is a low-level file operation function that works with various
+ *      file streams, including standard output, standard error, and regular files.
  */
 function log_message( $message ) {
 	fwrite( STDOUT, $message . PHP_EOL );
 }
 
 /**
- * Log an error message to STDERR
+ * Writes an error message prefixed with "Error: " to the standard error output (STDERR) and terminates the script
+ * with a status code of 1. This function is typically used to report errors during script execution, where an
+ * immediate halt is necessary due to unrecoverable conditions. The message is appended with the PHP end-of-line
+ * constant (PHP_EOL) to ensure it is properly displayed on all operating systems.
  *
- * @param string $message
+ * @param string $message The error message to be logged. This string will be output as provided, but prefixed
+ *                        with "Error: " to indicate its nature, followed by a system-specific newline character.
+ *
+ * @return void This function does not return a value. It directly writes the error message to STDERR and then
+ *              terminates the script execution using `exit(1)`, indicating an error condition to the environment.
+ *
+ * @uses fwrite() to write the error message to STDERR. This function is used for low-level writing to file streams
+ *      or output streams, in this case, STDERR, which is specifically for error reporting.
+ * @uses exit() to terminate the script execution with a status code of 1, indicating an error has occurred. This is
+ *      a common practice in command-line scripts and applications to signal failure to the calling process or environment.
  */
 function error_message( $message ) {
 	fwrite( STDERR, 'Error: ' . $message . PHP_EOL );
@@ -69,21 +112,43 @@ function error_message( $message ) {
 }
 
 /**
- * Add a trailing slash to the string
+ * Ensures a single trailing slash is present at the end of a given string. This function first removes any existing
+ * trailing slashes from the input string to avoid duplication and then appends a single slash. It's commonly used
+ * to normalize file paths or URLs to ensure consistency in format, especially when concatenating paths or performing
+ * file system operations that expect a trailing slash.
+ *
+ * @param string $string The input string to which a trailing slash will be added. This could be a file path, URL,
+ *                       or any other string that requires a trailing slash for proper formatting or usage.
  *
- * @param string
- * @return string
+ * @return string The modified string with a single trailing slash appended at the end. If the input string already
+ *                has one or more trailing slashes, they will be trimmed to a single slash.
+ *
+ * @uses rtrim() to remove any existing trailing slashes from the input string before appending a new trailing slash.
+ *      This ensures that the result consistently has exactly one trailing slash, regardless of the input string's initial state.
  */
 function trailingslashit( $string ) {
 	return rtrim( $string, '/' ) . '/';
 }
 
 /**
- * Process JUnit test results and return JSON. The resulting JSON will only
- * include failures.
+ * Parses JUnit XML formatted string to extract test results, focusing specifically on test failures and errors.
+ * The function converts the XML data into a structured JSON format that summarizes the overall test outcomes,
+ * including the total number of tests, failures, errors, and execution time. Only test suites and cases that
+ * contain failures or errors are included in the final JSON output. This function is useful for automated test
+ * result analysis, continuous integration reporting, or any scenario where a quick summary of test failures and
+ * errors is needed.
+ *
+ * @param string $xml_string The JUnit XML data as a string. This should be well-formed XML representing the results
+ *                           of test executions, typically generated by testing frameworks compatible with JUnit reporting.
+ *
+ * @return string A JSON encoded string that represents a summary of the test results, including overall metrics and
+ *                detailed information about each failed or errored test case. The JSON structure will include keys
+ *                for 'tests', 'failures', 'errors', 'time', and 'testsuites', where 'testsuites' is an array of test
+ *                suites that contains the failures or errors.
  *
- * @param  string $xml String containing JUnit results.
- * @return string
+ * @uses simplexml_load_string() to parse the JUnit XML data into an object for easy access and manipulation of the XML elements.
+ * @uses xpath() to query specific elements within the XML structure, particularly to find test suites with failures or errors.
+ * @uses json_encode() to convert the array structure containing the test results into a JSON formatted string.
  */
 function process_junit_xml( $xml_string )
 {
@@ -138,14 +203,26 @@ function process_junit_xml( $xml_string )
 }
 
 /**
- * Upload the results to the reporting API.
- *
- * @param  string $content The processed JUnit XML.
- * @param  string $rev     The SVN revision.
- * @param  string $message The SVN message.
- * @param  string $env     The environment data in JSON format
- * @param  string $api_key The API key for the reporting API.
- * @return array           Response from the reporting API.
+ * Submits test results along with associated metadata to a specified reporting API. The function constructs
+ * a POST request containing the test results, SVN revision, SVN message, environment data, and uses an API key
+ * for authentication. The reporting API's URL is retrieved from an environment variable; if not found, a default
+ * URL is used. This function is typically used to automate the reporting of test outcomes to a centralized system
+ * for analysis, tracking, and historical record-keeping.
+ *
+ * @param string $results The test results in a processed format (e.g., JSON) ready for submission to the reporting API.
+ * @param string $rev     The SVN revision associated with the test results. This often corresponds to a specific code
+ *                        commit or build identifier.
+ * @param string $message The SVN commit message associated with the revision, providing context or notes about the changes.
+ * @param string $env     The environment data in JSON format, detailing the conditions under which the tests were run,
+ *                        such as operating system, PHP version, etc.
+ * @param string $api_key The API key for authenticating with the reporting API, ensuring secure and authorized access.
+ *
+ * @return array An array containing two elements: the HTTP status code of the response (int) and the body of the response
+ *               (string) from the reporting API. This can be used to verify successful submission or to handle errors.
+ *
+ * @uses curl_init(), curl_setopt(), and curl_exec() to perform the HTTP POST request to the reporting API.
+ * @uses json_encode() to encode the data payload as a JSON string for submission.
+ * @uses base64_encode() to encode the API key for HTTP Basic Authentication in the Authorization header.
  */
 function upload_results( $results, $rev, $message, $env, $api_key ) {
 	$WPT_REPORT_URL = getenv( 'WPT_REPORT_URL' );
@@ -181,7 +258,26 @@ function upload_results( $results, $rev, $message, $env, $api_key ) {
 }
 
 /**
- * Get the environmental details
+ * Collects and returns an array of key environment details relevant to the application's context. This includes
+ * the PHP version, installed PHP modules with their versions, system utilities like curl and OpenSSL versions,
+ * MySQL version, and operating system details. This function is useful for diagnostic purposes, ensuring
+ * compatibility, or for reporting system configurations in debugging or error logs.
+ *
+ * The function checks for the availability of specific PHP modules and system utilities and captures their versions.
+ * It uses shell commands to retrieve system information, which requires the PHP environment to have access to these
+ * commands and appropriate permissions.
+ *
+ * @return array An associative array containing detailed environment information. The array includes:
+ *               - 'php_version': The current PHP version.
+ *               - 'php_modules': An associative array of selected PHP modules and their versions.
+ *               - 'system_utils': Versions of certain system utilities such as 'curl', 'imagemagick', 'graphicsmagick', and 'openssl'.
+ *               - 'mysql_version': The version of MySQL installed.
+ *               - 'os_name': The name of the operating system.
+ *               - 'os_version': The version of the operating system.
+ *
+ * @uses phpversion() to get the PHP version and module versions.
+ * @uses shell_exec() to execute system commands for retrieving MySQL version, OS details, and versions of utilities like curl and OpenSSL.
+ * @uses class_exists() to check for the availability of the Imagick and Gmagick classes for version detection.
  */
 function get_env_details() {
 	$env = array(

From 7cb6853aae66294834dfedb9b374a5bf19a69e70 Mon Sep 17 00:00:00 2001
From: Javier Casares <javier@casares.org>
Date: Wed, 7 Feb 2024 08:10:48 +0100
Subject: [PATCH 3/4] fox

---
 cleanup.php | 1 -
 1 file changed, 1 deletion(-)

diff --git a/cleanup.php b/cleanup.php
index 49d6a0d..e584c6c 100644
--- a/cleanup.php
+++ b/cleanup.php
@@ -1,5 +1,4 @@
 <?php
-
 /**
  * This script is responsible for cleaning up the test environment after a run of the WordPress PHPUnit Test Runner.
  * It ensures that temporary directories and files created during the test process are properly deleted.

From cb81a6ae0dfe1646012b8fa405dc796ec838790b Mon Sep 17 00:00:00 2001
From: Javier Casares <javier@casares.org>
Date: Wed, 7 Feb 2024 08:11:16 +0100
Subject: [PATCH 4/4] fix

---
 prepare.php | 1 -
 report.php  | 1 -
 test.php    | 1 -
 3 files changed, 3 deletions(-)

diff --git a/prepare.php b/prepare.php
index 53b6f03..7283923 100644
--- a/prepare.php
+++ b/prepare.php
@@ -1,5 +1,4 @@
 <?php
-
 /**
  * This script prepares the environment for WordPress unit tests.
  * It sets up the necessary variables and configurations based on the environment.
diff --git a/report.php b/report.php
index 32de8ff..b690f76 100644
--- a/report.php
+++ b/report.php
@@ -1,5 +1,4 @@
 <?php
-
 /**
  * This script is responsible for reporting the results of the PHPUnit test runs to WordPress.org.
  * It gathers necessary information such as the SVN revision, test run messages, and the junit.xml
diff --git a/test.php b/test.php
index f5c7551..18b3f4f 100644
--- a/test.php
+++ b/test.php
@@ -1,5 +1,4 @@
 <?php
-
 /**
  * Executes the PHPUnit test suite within the WordPress testing environment.
  * This script is designed to run tests either locally or on a remote server based on the environment setup.