Images in plugin used with img get marked as errors

[sc0ttkclark]

Related to this sniff:

plugin-check/phpcs-sniffs/PluginCheck/Sniffs/CodeAnalysis/ImageFunctionsSniff.php

Line 62 in 02aeb3e

$this->phpcsFile->addError(

ERROR | PluginCheck.CodeAnalysis.ImageFunctions.NonEnqueuedImage | Images should be added using wp_get_attachment_image() or similar functions

The problem here is that plugins have their own <img src="<?php echo esc_url( $image_from_plugin) ); ?>" ... /> image tags output. These trigger the ERROR which seems like it should be a WARNING perhaps?

[ernilambar]

Today, I faced same issue with following code:

<div><img src="<?php echo plugins_url( 'img/logo.png', __FILE__ ) ?>" alt="Logo" class="pe-3" /></div>

[swissspidy]

Sounds reasonable to make it a warning instead. PRs welcome :-)

---

Today, I faced same issue with following code:

Aside: you should really specify width & height attributes :)