Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content updates from Page Editor #518

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 22, 2024

The following pages have been updated in the Page Editor.

State of the Word [https://wordpress.org/state-of-the-word/]

Screenshots: https://github.com/WordPress/wporg-main-2022/actions/runs/11980593128/artifacts/2226559004

Please review, merge, and deploy.

@ryelle
Copy link
Contributor

ryelle commented Nov 22, 2024

@eidolonnight I think you've made these changes, can you add a note about what changed & if it's ready for deployment? Also, FYI, these changes are string changes, so they'll reset the Japanese page and show English in the places it's changed, until someone goes in and translates the new strings.

@eidolonnight
Copy link

Changes were requested by Sarah Glenn. Copy edits highlight the inclusion of multiple speakers this year and update the instructions for tickets and host parties.

If the fallback is not the previous translated text, let's hold off on deployment until we can have a translator ready and ensure that these edits are final.

@ryelle
Copy link
Contributor

ryelle commented Nov 22, 2024

If the fallback is not the previous translated text, let's hold off on deployment until we can have a translator ready and ensure that these edits are final.

There is no fallback, it will just display the English until the translations are there. And it even with a translator on hand, it can take at least 24hrs for the translations to process through — merging/deploying here will put the strings in the system within an hour, then a translator will submit the Japanese strings. They might need approval from a Japanese translation editor. Once approved, the system that builds language packs from these translations is run every 24hrs around 1:00 UTC. After that, someone with a sandbox needs to deploy to push out the changes.

I'm only explaining all of that to be clear that it won't be immediate, even with someone standing by.

Here's a comparison of what will change:

Production Once deployed
sotw-before sotw-after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants