From edf800b9eeeeb2c7c679595c93f0649f27f6ad4c Mon Sep 17 00:00:00 2001 From: Ioannis Kalyvas <giannis.kalyvas@workable.com> Date: Wed, 10 Jul 2024 13:44:13 +0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Nikos Kostoulas <nikostoulas@users.noreply.github.com> --- docs/integrations/kafka.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/integrations/kafka.md b/docs/integrations/kafka.md index 328583dd..4354fec1 100644 --- a/docs/integrations/kafka.md +++ b/docs/integrations/kafka.md @@ -243,7 +243,7 @@ Once the new group ids are created you can remove the code that copies their off If you are using the renameGroupIds (before creating your consumers) your consumers will continue reading messages from the offset specified from the old groupId regardless if you set the fromBeginning configuration. FromBeginning configuration will be used if the groupId, topic is not found in kafka. -## Migrating from orka < 5.x.x +## Migrating from orka < 4.x.x Since Orka 5.x.x, the required KafkaJS version is ^2.x.x (more info on the KafkaJS changes [here](https://kafka.js.org/docs/migration-guide-v2.0.0)) @@ -251,7 +251,7 @@ Since Orka 5.x.x, the required KafkaJS version is ^2.x.x The only possible implication is the update of the DefaultPartitioner (https://kafka.js.org/docs/migration-guide-v2.0.0#producer-new-default-partitioner). This may case issues in partition-aware environments, since some messages may be produced in different partitions than they would with the previous default partitioner. -By default, Orka ^5.x.x will use the new DefaultPartitioner (previously named JavaCompatiblePartitioner). +By default, Orka ^4.x.x will use the new DefaultPartitioner (previously named JavaCompatiblePartitioner). You can use the previous DefaultPartitioner (now renamed to LegacyPartitioner) with: ```js