Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Datadog traces for health #234

Open
klouvas opened this issue Mar 29, 2021 · 4 comments
Open

Fix Datadog traces for health #234

klouvas opened this issue Mar 29, 2021 · 4 comments

Comments

@klouvas
Copy link
Contributor

klouvas commented Mar 29, 2021

Based on the configuration defined in orka for datadog metrics there should NOT be any traces for health endpoint in datadog. Based on the career pages datadog dashboard we see that some requests are traced.

@nikostoulas
Copy link
Contributor

It seems that we have a typo in the configuration as seen here: https://docs.datadoghq.com/tracing/setup_overview/custom_instrumentation/nodejs?tab=locally

Datadog expects blocklist not blacklist.

@nikostoulas
Copy link
Contributor

Care to fix this @klouvas ?

@klouvas
Copy link
Contributor Author

klouvas commented Mar 29, 2021

i checked about that and in version [email protected] that is used in orka the blacklist option is deprecated but it's not removed.
https://github.com/DataDog/dd-trace-js/blob/v0.30.5/packages/dd-trace/src/plugins/util/urlfilter.js#L14

@nikostoulas
Copy link
Contributor

That's weird then. Possibly needs some debugging to figure out what is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants