Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarking - unnecessary line break #66

Open
vedran-kasalica opened this issue May 6, 2024 · 4 comments
Open

Benchmarking - unnecessary line break #66

vedran-kasalica opened this issue May 6, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@vedran-kasalica
Copy link
Member

vedran-kasalica commented May 6, 2024

When visualising the runtime benchmarks if the font is large enough there is a linebreak on the status of failed workflows, even though there is plenty of horizontal space to expand the table, see:
Screenshot 2024-05-06 at 19 48 00

Although a bit less important, it would be nice if the header of the column would only break between "STATUS" and the first parenthesis when needed (see #66 (comment)).

@vedran-kasalica vedran-kasalica added the enhancement New feature or request label May 6, 2024
@magnuspalmblad
Copy link
Contributor

The benchmark line break is the major offender here, but if you or @kretep are looking into this, maybe also look into the column headers. The first one could use a break between "STATUS" and the first parenthesis. "PROTEINS IDENTIFIED" could be changed into "PROTEINS" and "GO-TERMS IDENTIFIED" into "GO-TERMS" to keep all column headers in two rows?

@vedran-kasalica
Copy link
Member Author

vedran-kasalica commented May 6, 2024

I was thinking about the same, STATUS does break in a weird way. We will look into it, but it might not be so trivial considering that the table (including the headers) is parsed from a json file. I just updated the 2 column names as you suggested.

@vedran-kasalica
Copy link
Member Author

I just looked into it and they are treated as 2 separate strings, one is the description (e.g., “status”) and the other one is units (e.g., “✓ or ✗”), so enforcing linebreak only in between the 2 should not be difficult.

@magnuspalmblad
Copy link
Contributor

This would be worth a try - it may give the table a more consistent look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants