Skip to content

Commit

Permalink
Merge pull request #66 from Workiva/dont_publish_internally
Browse files Browse the repository at this point in the history
FEA-2972: Dont publish internally
  • Loading branch information
rmconsole6-wk authored Nov 20, 2023
2 parents 42fbe43 + 679235f commit 6b2790f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 22 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/dart_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
fail-fast: false
matrix:
sdk:
- 2.13.4
- 2.19.6
# Commented out until we upgrade to Dart 3
# - beta
Expand All @@ -37,7 +36,7 @@ jobs:
run: dart run dependency_validator
- name: Check formatting
run: dart format --output=none --set-exit-if-changed .
if: ${{ matrix.sdk == 'stable' }}
if: ${{ matrix.sdk == '2.19.6' }}
- name: Analyze project source
run: dart analyze
- name: Run tests
Expand Down
8 changes: 1 addition & 7 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,10 +1,4 @@
FROM drydock-prod.workiva.net/workiva/dart2_base_image:2
WORKDIR /build/
ADD . /build/

ADD pubspec.yaml pubspec.yaml
RUN dart pub get

RUN tar -cvzf /build/assets.tar.gz -C lib sockjs.js sockjs.js.map sockjs_prod.js sockjs_prod.js.map
ARG BUILD_ARTIFACTS_CDN=/build/assets.tar.gz

FROM scratch
19 changes: 6 additions & 13 deletions skynet.yaml
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
name: verify-github-actions
description: Verify that the github actions run passed, this is needed to make pipelines pass without manual intervention
contact: 'Frontend Frameworks Architecture / #support-frontend-architecture'
image: drydock.workiva.net/workiva/skynet-images:3728345 # Uses the image from this branch: https://github.com/Workiva/skynet-images/pull/127
description: no-op
image: drydock.workiva.net/workiva/skynet-images:bash_curl_alpinelatest-latest

size: small
timeout: 600
timeout: short

run:
on-tag: true
on-pull-request: true
on-promotion: true
when-modified-file-name-is:
- skynet.yaml

env:
# encrypted github token used for requests to api.github.com
- secure: dnIrN6NR/QVFWqgHu98at/vrwT07wNoneulr+5rY4jdWVKmToyB5HYQplmxJC3M6Ju9fao4ZnnuXMRWHU4bBtR8Lkm0=

scripts:
- python3 /actions/verify_github_actions.py
- echo "See .github/workflows/dart_ci.yaml for tests"

0 comments on commit 6b2790f

Please sign in to comment.