Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My booked options showing deleted bookings #749

Open
mikeaveli007 opened this issue Dec 5, 2024 · 0 comments
Open

My booked options showing deleted bookings #749

mikeaveli007 opened this issue Dec 5, 2024 · 0 comments

Comments

@mikeaveli007
Copy link

mikeaveli007 commented Dec 5, 2024

Describe the bug
If a user books an option and then either cancels or is removed from the option, it will still show in the 'My booked options' page ('/mod/booking/mybookings.php'). Is this expected behavior?

Versions uses
Moodle version: 4.1
Boooking version: 8.8.3

To Reproduce
Steps to reproduce the behavior:

  1. Book and option
  2. Cancel the booking or delete it
  3. Go to My booked options page '/mod/booking/mybookings.php'
  4. Cancelled/Deleted booking still shows

Expected behavior
I would expect for my canceled bookings to either not appear on the my booked options page or at least show some indication that it is cancelled, perhaps in the status column.

Additional context
Looking at the code and it seems that in the 'booking_answers' table, the waitinglist column is set to '5' when it is cancelled/deleted. That coincides with the 'MOD_BOOKING_STATUSPARAM_DELETED' constant as defined in 'lib.php'.
However, it looks like the query in 'mybookings.php' does not filter out those deleted answers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant